Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2804673003: Move CSSCounterValue & CSSCursorImageValue to the namespace blink::cssvalue. (Closed)

Created:
3 years, 8 months ago by slangley
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CSSCounterValue & CSSCursorImageValue to the namespace blink::cssvalue. This is a continuation of other work to move CSS.*Value types to the nested namespace blink::cssvalue to avoid name collisions. I will be moving over type 2 or 3 at a time per CL. In some cases we need to temporarily introduce using statements while we're shuffling the classes around. These will be cleaned up once all types have been moved to blink::cssvalue. BUG=667961 Review-Url: https://codereview.chromium.org/2804673003 Cr-Commit-Position: refs/heads/master@{#462740} Committed: https://chromium.googlesource.com/chromium/src/+/4d188dd210489eb0a70bd66af0a1cf1400331399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/CSSCounterValue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCounterValue.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCursorImageValue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCursorImageValue.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPICursor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
slangley
3 years, 8 months ago (2017-04-06 00:39:26 UTC) #2
meade_UTC10
lgtm \o/
3 years, 8 months ago (2017-04-06 03:08:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804673003/1
3 years, 8 months ago (2017-04-06 05:01:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/416405)
3 years, 8 months ago (2017-04-06 07:25:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804673003/1
3 years, 8 months ago (2017-04-06 23:44:34 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:42:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d188dd210489eb0a70bd66af0a1...

Powered by Google App Engine
This is Rietveld 408576698