Image Capture: make sure applyConstraints() only works for ImageCapture constraints

Image Capture: make sure applyConstraints() only works for ImageCapture constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of the TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it

LayoutTests updated/extended.

[1] https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstraints#Return_value

BUG=700607, 708723
Review-Url: https://codereview.chromium.org/2804653003
Cr-Commit-Position: refs/heads/master@{#462531}
Committed: https://chromium.googlesource.com/chromium/src/+/1d5b6a1cd0258c12363b53f0d382471141463abe

[mcasas, 2017-04-05 19:33:43]

Description was changed from

==========
Image Capture:

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed;
 - derives to clearMediaTrackConstraints() if the constraint set is
 empty (after spec issue somehow clarified it).

 - lands ImageCapture::clearMediaTrackConstraints()
 - cleans up the TODO()s in ImageCapture.


BUG=700607, 708723
==========

to

==========
Image Capture: make sure applyConstraints() only exists for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed;

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of thel TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it 

 - adds ImageCapture::clearMediaTrackConstraints()

BUG=700607, 708723
==========

[mcasas, 2017-04-05 21:25:38]

Description was changed from

==========
Image Capture: make sure applyConstraints() only exists for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed;

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of thel TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it 

 - adds ImageCapture::clearMediaTrackConstraints()

BUG=700607, 708723
==========

to

==========
Image Capture: make sure applyConstraints() only exists for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is  
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of thel TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it 

 - adds ImageCapture::clearMediaTrackConstraints()

LayoutTests updated/extended.

[1]
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstr...

BUG=700607, 708723
==========

[mcasas, 2017-04-05 21:26:55]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:27:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-04-05 21:31:45]

mcasas@chromium.org changed reviewers:
+ foolip@chromium.org, guidou@chromium.org

[mcasas, 2017-04-05 21:31:46]

guidou@ PTAL

foolip@ FYI/PTAL

 -- this CL unblocks releasing applyConstraints() for Image
Capture while rejecting the rest of the potential constraints.

[mcasas, 2017-04-05 21:32:35]

Description was changed from

==========
Image Capture: make sure applyConstraints() only exists for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is  
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of thel TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it 

 - adds ImageCapture::clearMediaTrackConstraints()

LayoutTests updated/extended.

[1]
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstr...

BUG=700607, 708723
==========

to

==========
Image Capture: make sure applyConstraints() only works for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is  
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of the TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it 

LayoutTests updated/extended.

[1]
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstr...

BUG=700607, 708723
==========

[commit-bot: I haz the power, 2017-04-05 23:05:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 23:05:34]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2017-04-06 16:14:02]

lgtm

[mcasas, 2017-04-06 16:42:34]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:43:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 17:31:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491496954740250,
"parent_rev": "c9f101b745929a50b391abf446cefb6b2f4b4bd6", "commit_rev":
"1d5b6a1cd0258c12363b53f0d382471141463abe"}

[commit-bot: I haz the power, 2017-04-06 17:41:41]

Description was changed from

==========
Image Capture: make sure applyConstraints() only works for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is  
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of the TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it 

LayoutTests updated/extended.

[1]
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstr...

BUG=700607, 708723
==========

to

==========
Image Capture: make sure applyConstraints() only works for ImageCapture
constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of the TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it

LayoutTests updated/extended.

[1]
https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstr...

BUG=700607, 708723

Review-Url: https://codereview.chromium.org/2804653003
Cr-Commit-Position: refs/heads/master@{#462531}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d5b6a1cd0258c12363b53f0d382...
==========

[commit-bot: I haz the power, 2017-04-06 17:41:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d5b6a1cd0258c12363b53f0d382...