Expose the ValueSerializer data format version as a compile-time constant.

Expose the ValueSerializer data format version as a compile-time constant.

BUG=chromium:704293
Review-Url: https://codereview.chromium.org/2804643006
Cr-Commit-Position: refs/heads/master@{#44945}
Committed: https://chromium.googlesource.com/v8/v8/+/a16c3c910548e37eb62bb467fea706a21f6a2d46

[jbroman, 2017-04-06 00:42:50]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 00:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:46:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[jbroman, 2017-04-06 15:21:24]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 15:21:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 15:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:52:58]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-04-06 20:26:48]

Description was changed from

==========
Expose the ValueSerializer data format version as a compile-time constant.

BUG=
==========

to

==========
Expose the ValueSerializer data format version as a compile-time constant.

BUG=chromium:704293
==========

[jbroman, 2017-04-11 15:11:07]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2017-04-11 15:11:07]

On the Chromium-side review, reviewers wanted this exposed as a compile-time
constant that we could use in the browser process. WDYT?

Chromium (part 1): https://codereview.chromium.org/2773823002
V8: this CL
Chromium (part 2): https://codereview.chromium.org/2801053003

I put it in its own header, but I could understand putting it in v8-version.h or
something like that if that's preferred. We currently forbid including v8.h in
Chromium browser code.

[Jakob Kummerow, 2017-04-11 15:59:41]

I'm fine with this; but CLs that make it difficult to revert V8 rolls must not
land in the branching week. Please wait until next week.

[jbroman, 2017-04-25 15:45:38]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:45:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 15:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:45:50]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[jbroman, 2017-04-25 15:49:38]

It is >= "next week". :)

[Jakob Kummerow, 2017-04-26 09:35:58]

lgtm

[jbroman, 2017-04-26 14:44:14]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-26 14:44:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 15:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 15:47:39]

Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[jbroman, 2017-04-26 19:51:07]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-26 19:51:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:29:22]

Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[jbroman, 2017-04-27 14:43:36]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-27 14:43:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 15:14:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493304216430930,
"parent_rev": "5317d43e0c4419fdd3b845c8fcbaafd92bf3a75a", "commit_rev":
"a16c3c910548e37eb62bb467fea706a21f6a2d46"}

[commit-bot: I haz the power, 2017-04-27 15:14:48]

Description was changed from

==========
Expose the ValueSerializer data format version as a compile-time constant.

BUG=chromium:704293
==========

to

==========
Expose the ValueSerializer data format version as a compile-time constant.

BUG=chromium:704293

Review-Url: https://codereview.chromium.org/2804643006
Cr-Commit-Position: refs/heads/master@{#44945}
Committed:
https://chromium.googlesource.com/v8/v8/+/a16c3c910548e37eb62bb467fea706a21f6...
==========

[commit-bot: I haz the power, 2017-04-27 15:14:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a16c3c910548e37eb62bb467fea706a21f6...