[ios] Fix build instruction and scripts.

[ios] Fix build instruction and scripts.

-   The script setup-gn.py is not run as part of `gclient runhooks`
    upstream, so update the documentation to not say the opposite.

-   Fix an error in the setup-gn.py that treated any non-empty
    value for FORCE_MAC_TOOLCHAIN environment variable as a `True`
    (in python any non-empty string is `True` in a boolean context).

BUG=None

Review-Url: https://codereview.chromium.org/2804633002
Cr-Commit-Position: refs/heads/master@{#462065}
Committed: https://chromium.googlesource.com/chromium/src/+/907b382a53b80e3c9aa0ad08a647355e16da2cd1

[sdefresne, 2017-04-05 12:13:20]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 12:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-05 12:16:45]

sdefresne@chromium.org changed reviewers:
+ lpromero@chromium.org

[sdefresne, 2017-04-05 12:16:46]

lpromero: Please take a look.
elawrence: FYI

[sdefresne, 2017-04-05 12:42:16]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 12:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-05 12:42:47]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-05 12:51:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 12:51:19]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-04-05 13:07:56]

lgtm

https://codereview.chromium.org/2804633002/diff/20001/docs/ios/build_instruct...
File docs/ios/build_instructions.md (left):

https://codereview.chromium.org/2804633002/diff/20001/docs/ios/build_instruct...
docs/ios/build_instructions.md:86: This script is run automatically by fetch (as
part of `gclient runhooks`).
When is it run then?

[sdefresne, 2017-04-05 14:28:21]

https://codereview.chromium.org/2804633002/diff/20001/docs/ios/build_instruct...
File docs/ios/build_instructions.md (left):

https://codereview.chromium.org/2804633002/diff/20001/docs/ios/build_instruct...
docs/ios/build_instructions.md:86: This script is run automatically by fetch (as
part of `gclient runhooks`).
On 2017/04/05 13:07:56, lpromero wrote:
> When is it run then?

It needs to be run manually as detailed in the paragraph at lines 100-102.

[sdefresne, 2017-04-05 14:28:28]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-04-05 14:28:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 14:34:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491402508417480,
"parent_rev": "889fe85b1ec6deaef84f7c1b3a186aa0a7a3f7f5", "commit_rev":
"907b382a53b80e3c9aa0ad08a647355e16da2cd1"}

[commit-bot: I haz the power, 2017-04-05 14:35:20]

Description was changed from

==========
[ios] Fix build instruction and scripts.

-   The script setup-gn.py is not run as part of `gclient runhooks`
    upstream, so update the documentation to not say the opposite.

-   Fix an error in the setup-gn.py that treated any non-empty
    value for FORCE_MAC_TOOLCHAIN environment variable as a `True`
    (in python any non-empty string is `True` in a boolean context).

BUG=None
==========

to

==========
[ios] Fix build instruction and scripts.

-   The script setup-gn.py is not run as part of `gclient runhooks`
    upstream, so update the documentation to not say the opposite.

-   Fix an error in the setup-gn.py that treated any non-empty
    value for FORCE_MAC_TOOLCHAIN environment variable as a `True`
    (in python any non-empty string is `True` in a boolean context).

BUG=None

Review-Url: https://codereview.chromium.org/2804633002
Cr-Commit-Position: refs/heads/master@{#462065}
Committed:
https://chromium.googlesource.com/chromium/src/+/907b382a53b80e3c9aa0ad08a647...
==========

[commit-bot: I haz the power, 2017-04-05 14:35:21]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/907b382a53b80e3c9aa0ad08a647...

[elawrence, 2017-04-05 16:18:10]

On 2017/04/05 12:16:46, sdefresne wrote:
> lpromero: Please take a look.
> elawrence: FYI

Thanks for the quick turnaround!