Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2804623005: MD WebUI: Explicitly set text color in cr-action-menu (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam, dpapad
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Explicitly set text color in cr-action-menu This fixes an issue where the menu would appear blank in MD Downloads and Bookmarks. BUG=708892 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2804623005 Cr-Commit-Position: refs/heads/master@{#462930} Committed: https://chromium.googlesource.com/chromium/src/+/00283c09b0e6479e55fd4630f49601f167fc10b0

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html View 2 chunks +1 line, -2 lines 1 comment Download

Messages

Total messages: 15 (10 generated)
tsergeant
I'm really confused about how this happened -- the bug affects MD Bookmarks, but I ...
3 years, 8 months ago (2017-04-07 01:53:10 UTC) #4
tsergeant
Oh, figured it out: the bug was always affecting MD Downloads, but only started affecting ...
3 years, 8 months ago (2017-04-07 03:02:23 UTC) #7
dpapad
lgtm
3 years, 8 months ago (2017-04-07 17:03:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804623005/20001
3 years, 8 months ago (2017-04-07 18:11:22 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 18:24:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00283c09b0e6479e55fd4630f496...

Powered by Google App Engine
This is Rietveld 408576698