Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2804593003: MD Settings: Search engine: Request hotword info on engine change (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
fukino, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Search engine: Request hotword info on engine change When a reset or other external search engine change occurs, we also need to re-request the hotword info. BUG=708451 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2804593003 Cr-Commit-Position: refs/heads/master@{#462588} Committed: https://chromium.googlesource.com/chromium/src/+/e6a1fd7a7f2fc50b1fa4311ebd75d43195d69d00

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M chrome/browser/resources/settings/search_page/search_page.js View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/search_page_test.js View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
stevenjb
3 years, 8 months ago (2017-04-06 01:27:04 UTC) #3
fukino
lgtm. Thank you for fixing this!
3 years, 8 months ago (2017-04-06 02:37:57 UTC) #4
michaelpg
lgtm
3 years, 8 months ago (2017-04-06 14:51:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804593003/1
3 years, 8 months ago (2017-04-06 16:32:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/399571)
3 years, 8 months ago (2017-04-06 17:23:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804593003/20001
3 years, 8 months ago (2017-04-06 17:55:01 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:43:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6a1fd7a7f2fc50b1fa4311ebd75...

Powered by Google App Engine
This is Rietveld 408576698