[Offline Pages] Remove activation time for background loading.

[Offline Pages] Remove activation time for background loading.

Since activation time is no longer used, remove all codes related.

BUG=705103
Review-Url: https://codereview.chromium.org/2804543003
Cr-Commit-Position: refs/heads/master@{#463097}
Committed: https://chromium.googlesource.com/chromium/src/+/92dd0fe1f2cc4acc05593a8f64a26f55f1f86521

[romax, 2017-04-06 00:37:47]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 00:38:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[romax, 2017-04-06 17:51:02]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[romax, 2017-04-06 17:51:18]

romax@chromium.org changed reviewers:
+ petewil@chromium.org

[romax, 2017-04-06 17:51:18]

PTAL, thanks.

[commit-bot: I haz the power, 2017-04-06 17:52:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:57:48]

Dry run: This issue passed the CQ dry run.

[Pete Williamson, 2017-04-07 18:18:58]

https://codereview.chromium.org/2804543003/diff/20001/components/offline_page...
File components/offline_pages/core/background/request_queue_store_sql.cc (left):

https://codereview.chromium.org/2804543003/diff/20001/components/offline_page...
components/offline_pages/core/background/request_queue_store_sql.cc:38: "
activation_time INTEGER NOT NULL DEFAULT 0,"
Instead of removing activation time from the schema, should we just leave it
alone for now?  So I'd leave this code setting it up, and not do a schema
migration until we need to.

[fgorski, 2017-04-07 18:28:52]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2017-04-07 18:28:53]

https://codereview.chromium.org/2804543003/diff/20001/components/offline_page...
File components/offline_pages/core/background/request_queue_store_sql.cc (left):

https://codereview.chromium.org/2804543003/diff/20001/components/offline_page...
components/offline_pages/core/background/request_queue_store_sql.cc:38: "
activation_time INTEGER NOT NULL DEFAULT 0,"
On 2017/04/07 18:18:58, Pete Williamson wrote:
> Instead of removing activation time from the schema, should we just leave it
> alone for now?  So I'd leave this code setting it up, and not do a schema
> migration until we need to.

That's actually not a bad idea. We would only have to make minor changes to this
file and put a huge comment somewhere here that next time we add a field,
activation_time should go as well. Upgrade can be postponed till then.

[romax, 2017-04-07 21:01:20]

addressed comments:
Undid the removal related with schema, and also brought back the activation_time
field in SavePageRequest to keep the consistency. Or do you prefer to remove the
field and have some dumb value in sql level?

[Pete Williamson, 2017-04-07 21:30:05]

Let's also remove it from save_page_request.  It will simplify the code.  We
could add a TODO to consider removing it from the sql database next time we
change the schema.

[romax, 2017-04-07 23:41:46]

removed the field from SavePageRequest and also related code in store_sql.cc,
leaving some default values as 0.
Also added a TODO in the header for future removal in next schema change.

[Pete Williamson, 2017-04-08 00:01:00]

lgtm

[romax, 2017-04-08 00:09:05]

The CQ bit was checked by romax@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 00:09:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:01:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 01:01:15]

Dry run: This issue passed the CQ dry run.

[romax, 2017-04-08 01:08:33]

The CQ bit was checked by romax@chromium.org

[commit-bot: I haz the power, 2017-04-08 01:09:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 01:17:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491613713019810,
"parent_rev": "e2a2e605169bf31e451e1dc3f8e3e245c6fc18e5", "commit_rev":
"92dd0fe1f2cc4acc05593a8f64a26f55f1f86521"}

[commit-bot: I haz the power, 2017-04-08 01:18:38]

Description was changed from

==========
[Offline Pages] Remove activation time for background loading.

Since activation time is no longer used, remove all codes related.

BUG=705103
==========

to

==========
[Offline Pages] Remove activation time for background loading.

Since activation time is no longer used, remove all codes related.

BUG=705103

Review-Url: https://codereview.chromium.org/2804543003
Cr-Commit-Position: refs/heads/master@{#463097}
Committed:
https://chromium.googlesource.com/chromium/src/+/92dd0fe1f2cc4acc05593a8f64a2...
==========

[commit-bot: I haz the power, 2017-04-08 01:18:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/92dd0fe1f2cc4acc05593a8f64a2...