Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2804523002: Fix mistmached |GetDisplayNearest{Window,View}| param type (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, jam, sadrul, oshima+watch_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mistmached |GetDisplayNearest{Window,View}| param type Fixes the mismatched parameter type (gfx::Native{Window,View}) used for |display::Screen::GetDisplayNearest{Window,View}| in ash. This does not make any functional difference since gfx::NativeWindow and NativeView are of same type when aura is on. The changes are just for correctness' sake. BUG=699891 Review-Url: https://codereview.chromium.org/2804523002 Cr-Commit-Position: refs/heads/master@{#462449} Committed: https://chromium.googlesource.com/chromium/src/+/e18e618f9e27b12ad26277f7a692766b513694a7

Patch Set 1 #

Patch Set 2 : window #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M ash/common/system/tray/system_tray.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ash/common/wm/window_cycle_list.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ash/display/screen_ash.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/laser/laser_pointer_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M ash/mus/screen_mus.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/mus/screen_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Jinsuk Kim
3 years, 8 months ago (2017-04-05 07:04:01 UTC) #7
oshima
Can you change GetNativeWindow instead because there is no real NativewView in aura?
3 years, 8 months ago (2017-04-05 10:31:24 UTC) #8
Jinsuk Kim
Updated to use |GetDisplayNearestWindow|.
3 years, 8 months ago (2017-04-05 23:16:59 UTC) #9
oshima
lgtm
3 years, 8 months ago (2017-04-06 12:46:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804523002/20001
3 years, 8 months ago (2017-04-06 12:52:55 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 13:24:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e18e618f9e27b12ad26277f7a692...

Powered by Google App Engine
This is Rietveld 408576698