Issue 2804473002: Rough prototype of deferred TBM results processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2804473002: Rough prototype of deferred TBM results processing.

Created:
3 years, 8 months ago by vmiura

Modified:
3 years, 8 months ago

Reviewers:
nednguyen

CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
catapult

Visibility:
Public.

More Reviews

Description

Rough prototype of deferred TBM results processing. BUG=chromium:708363

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -11 lines)			Patch
	M	telemetry/telemetry/internal/results/story_run.py	View		4 chunks	+9 lines, -2 lines	0 comments	Download
	M	telemetry/telemetry/web_perf/timeline_based_measurement.py	View		3 chunks	+23 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nednguyen

This patch is interesting but a bit scary at the same time because results is ...

3 years, 8 months ago (2017-04-07 03:26:47 UTC) #2

vmiura

3 years, 8 months ago (2017-04-07 03:53:55 UTC) #3

On 2017/04/07 03:26:47, nednguyen (slow til 4-10) wrote:
> This patch is interesting but a bit scary at the same time because results is
> the most common object shared by many different places in Telemetry.
> 
> Though I think it worths thinking about how we can save time here though.
Thanks
> for this CL!

Agreed.  The StoryRun results could be kept separate, but I am concerned about
inadvertently calling into any other parts of telemetry that may not be thread
safe.

Saving trace results to HTML is a time consuming piece which may be more
feasible to segregate on it's own.

TMBv2 runs in v8 so could be easier to parallelize with Python execution.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages