Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: telemetry/telemetry/internal/results/story_run.py

Issue 2804473002: Rough prototype of deferred TBM results processing.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/results/story_run.py
diff --git a/telemetry/telemetry/internal/results/story_run.py b/telemetry/telemetry/internal/results/story_run.py
index 078d0fcb5ef8c73cc5bc272acfa5b7b7cb79f1d9..49ee5ffc4f673bce4bebc8d2e46522e0b1d589f4 100644
--- a/telemetry/telemetry/internal/results/story_run.py
+++ b/telemetry/telemetry/internal/results/story_run.py
@@ -10,10 +10,14 @@ class StoryRun(object):
def __init__(self, story):
self._story = story
self._values = []
+ self._pending_threads = []
def AddValue(self, value):
self._values.append(value)
+ def AddResultThread(self, thread):
+ self._pending_threads.append(thread)
+
@property
def story(self):
return self._story
@@ -21,6 +25,9 @@ class StoryRun(object):
@property
def values(self):
"""The values that correspond to this story run."""
+ for t in self._pending_threads:
+ t.join()
+ self._pending_threads = []
return self._values
@property
@@ -38,7 +45,7 @@ class StoryRun(object):
To be precise: returns true if there is any SkipValue in self.values.
"""
- return any(isinstance(v, skip.SkipValue) for v in self.values)
+ return any(isinstance(v, skip.SkipValue) for v in self._values)
@property
def failed(self):
@@ -48,4 +55,4 @@ class StoryRun(object):
SkipValue in self.values.
"""
return not self.skipped and any(
- isinstance(v, failure.FailureValue) for v in self.values)
+ isinstance(v, failure.FailureValue) for v in self._values)
« no previous file with comments | « no previous file | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698