Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2804463002:
Move //net to public_deps in //components/dom_distiller/core (Closed)
DescriptionMove //net to public_deps in //components/dom_distiller/core
BUG=none
Review-Url: https://codereview.chromium.org/2804463002
Cr-Commit-Position: refs/heads/master@{#463018}
Committed: https://chromium.googlesource.com/chromium/src/+/3de411ec62537cdf662bf2d2ade0ebc54c3e3450
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by mattm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mattm@chromium.org changed reviewers: + bengr@chromium.org
Hi, distiller_url_fetcher.h includes net headers, therefore net should be in the public deps. Example error (assumes you change net/cert/x509_certificate.h to #include "third_party/boringssl/src/include/openssl/base.h"): In file included from ../../net/cert/x509_certificate.h:25:0, from ../../net/ssl/ssl_config.h:12, from ../../net/ssl/ssl_info.h:20, from ../../net/http/http_response_info.h:14, from ../../net/base/net_error_details.h:9, from ../../net/url_request/url_request.h:26, from ../../net/url_request/url_fetcher.h:19, from ../../components/dom_distiller/core/distiller_url_fetcher.h:12, from ../../components/dom_distiller/core/distiller.h:22, from ../../components/dom_distiller/core/fake_distiller.h:11, from ../../components/dom_distiller/core/fake_distiller.cc:5: ../../third_party/boringssl/src/include/openssl/base.h:68:33: fatal error: openssl/opensslconf.h: No such file or directory #include <openssl/opensslconf.h>
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
lgtm
The CQ bit was checked by mattm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491589259442320, "parent_rev":
"6a539b43629daa2a49d5603fea5ade7d48d31dd2", "commit_rev":
"a0236daefaf9482d6f515e18b7f93b30b5f2dc4f"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491589259442320, "parent_rev":
"9309a096d9fff76eceefaf529cf0a3df85617c13", "commit_rev":
"0219d11a8bd0c8f79be59932c9704d7ebc54f8a3"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491589259442320, "parent_rev":
"9309a096d9fff76eceefaf529cf0a3df85617c13", "commit_rev":
"40d3f7ef79605628e541fe628a551cf9d7e11068"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by mattm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491601960890660, "parent_rev":
"22f0a7ab19cbbd1b8cac600230f90e6b3147b37d", "commit_rev":
"3de411ec62537cdf662bf2d2ade0ebc54c3e3450"}
Message was sent while issue was closed.
Description was changed from ========== Move //net to public_deps in //components/dom_distiller/core BUG=none ========== to ========== Move //net to public_deps in //components/dom_distiller/core BUG=none Review-Url: https://codereview.chromium.org/2804463002 Cr-Commit-Position: refs/heads/master@{#463018} Committed: https://chromium.googlesource.com/chromium/src/+/3de411ec62537cdf662bf2d2ade0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3de411ec62537cdf662bf2d2ade0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
