Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2804443002: ❄ Infobar links (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, subresource-filter-reviews_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

❄ Infobar links Get rid of the copy-pasta by forcing all linkifying code to do the same thing: show a clickable non-underlined blue link. Also fixes how some infobars were inheriting from the (admittedly) screwy Java infobar hierarchy. BUG=705312 Review-Url: https://codereview.chromium.org/2804443002 Cr-Commit-Position: refs/heads/master@{#462205} Committed: https://chromium.googlesource.com/chromium/src/+/ee3cd20ca02aa2b2e00e96f125c10bb84cfb92eb

Patch Set 1 #

Messages

Total messages: 19 (12 generated)
gone
PTAL the respective infobars you own.
3 years, 8 months ago (2017-04-05 01:13:43 UTC) #4
benwells
lgtm, thanks
3 years, 8 months ago (2017-04-05 04:42:17 UTC) #5
melandory
lgtm!
3 years, 8 months ago (2017-04-05 08:11:45 UTC) #6
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-05 15:44:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804443002/1
3 years, 8 months ago (2017-04-05 20:29:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804443002/1
3 years, 8 months ago (2017-04-05 20:34:22 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 20:41:31 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee3cd20ca02aa2b2e00e96f125c1...

Powered by Google App Engine
This is Rietveld 408576698