Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/core/fileapi

BUG=707641
Review-Url: https://codereview.chromium.org/2804403003
Cr-Commit-Position: refs/heads/master@{#463401}
Committed: https://chromium.googlesource.com/chromium/src/+/99bc0460eec9022684af3ee7386774953186e6a5

[Hwanseung Lee, 2017-04-08 15:03:29]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/core/fileapi

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/core/fileapi

BUG=707641
==========

[Hwanseung Lee, 2017-04-08 15:03:29]

hs1217.lee@samsung.com changed reviewers:
+ alancutter@chromium.org, tkent@chromium.org

[Hwanseung Lee, 2017-04-08 15:03:39]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 15:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-08 15:25:29]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 15:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 16:51:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 16:51:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2017-04-08 22:59:53]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 23:00:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 01:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 01:55:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2017-04-09 02:35:34]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 02:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 05:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 05:20:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2017-04-09 08:23:29]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 08:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 10:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 10:46:06]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-09 11:09:57]

PTAL, thank you.

[tkent, 2017-04-09 23:00:20]

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/File.cpp (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/File.cpp:53: DCHECK_EQ(policy,
File::AllContentTypes);
You changed kAllContentTypes to AllContentTypes.  Is this buildable?

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp:304:
DCHECK(read_type_ != kReadAsArrayBuffer && read_type_ != kReadByClient);
Split this into two.
DCHECK_NE(read_type_, kReadAsArrayBuffer);
DCHECK_NE(read_type_, kReadByClient);

[alancutter (OOO until 2018), 2017-04-10 00:23:41]

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/Blob.cpp (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/Blob.cpp:62:
DCHECK(&registrable_object->Registry(), this);
DCHECK_EQ?

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/Blob.cpp:151: DCHECK(size, -1);
DCHECK_NE?

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/File.h (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/File.h:168: #endif
Why are these guards necessary?

[Hwanseung Lee, 2017-04-10 15:01:32]

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/Blob.cpp (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/Blob.cpp:62:
DCHECK(&registrable_object->Registry(), this);
On 2017/04/10 00:23:41, alancutter wrote:
> DCHECK_EQ?

Done.

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/Blob.cpp:151: DCHECK(size, -1);
On 2017/04/10 00:23:41, alancutter wrote:
> DCHECK_NE?

Done.

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/File.cpp (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/File.cpp:53: DCHECK_EQ(policy,
File::AllContentTypes);
On 2017/04/09 23:00:20, tkent wrote:
> You changed kAllContentTypes to AllContentTypes.  Is this buildable?

sorry it is mistypo.

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/File.h (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/File.h:168: #endif
On 2017/04/10 00:23:41, alancutter wrote:
> Why are these guards necessary?

HasValidFilePath() is inside of "#if DCHECK_IS_ON()"
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/fileapi/F...

ASSERT() is same.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/wtf/A...

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp (right):

https://codereview.chromium.org/2804403003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp:304:
DCHECK(read_type_ != kReadAsArrayBuffer && read_type_ != kReadByClient);
On 2017/04/09 23:00:20, tkent wrote:
> Split this into two.
> DCHECK_NE(read_type_, kReadAsArrayBuffer);
> DCHECK_NE(read_type_, kReadByClient);

Done.

[Hwanseung Lee, 2017-04-10 15:01:37]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:02:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:44:52]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-10 21:09:13]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-10 21:09:13]

lgtm

[commit-bot: I haz the power, 2017-04-10 21:09:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:31:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491858553259310,
"parent_rev": "69e056006f20f2973eafb2e95b7ea4395f3065db", "commit_rev":
"99bc0460eec9022684af3ee7386774953186e6a5"}

[commit-bot: I haz the power, 2017-04-10 21:39:05]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/core/fileapi

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/core/fileapi

BUG=707641

Review-Url: https://codereview.chromium.org/2804403003
Cr-Commit-Position: refs/heads/master@{#463401}
Committed:
https://chromium.googlesource.com/chromium/src/+/99bc0460eec9022684af3ee73867...
==========

[commit-bot: I haz the power, 2017-04-10 21:39:06]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/99bc0460eec9022684af3ee73867...