Adds ability for WindowManager to create display roots

Adds ability for WindowManager to create display roots

Prior to this patch mus would automatically create a Window for
each display and tell the WindowManager about it. This patch allows
the WindowManager to control this behavior so that if the
windowmanager wants to create the windows it can. In the new mode mus
still creates a window for the display, but it doesn't tell the
client. The expectation is the client eventually calls
SetDisplayRoot() with the client supplied window. When
SetDisplayRoot() is called mus wires up the window appropriately.

The expectation is ash transitions to observing newly added displays
using another mechanism and then tells mus about it.

BUG=708287
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2804403002
Cr-Commit-Position: refs/heads/master@{#463070}
Committed: https://chromium.googlesource.com/chromium/src/+/bb4b4de1b5a2b99c62e71b93f6c157e8290e3c3b

[sky, 2017-04-07 21:28:28]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:29:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-04-07 21:50:03]

Description was changed from

==========
Adds ability for WindowManager to create display roots

Prior to this patch mus would automatically create a Window for
each display and tell the WindowManager about it. This patch allows
the WindowManager to control this behavior so that if the
windowmanager wants to create the windows it can. In the new mode mus
still creates a window for the display, but it doesn't tell the
client. The expectation is the client eventually calls
SetDisplayRoot() with the client supplied window. When
SetDisplayRoot() is called mus wires up the window appropriately.

The expectation is ash transitions to observing newly added displays
using another mechanism and then tells mus about it.

BUG=708287
TEST=covered by tests
R=erg@chromium.org
==========

to

==========
Adds ability for WindowManager to create display roots

Prior to this patch mus would automatically create a Window for
each display and tell the WindowManager about it. This patch allows
the WindowManager to control this behavior so that if the
windowmanager wants to create the windows it can. In the new mode mus
still creates a window for the display, but it doesn't tell the
client. The expectation is the client eventually calls
SetDisplayRoot() with the client supplied window. When
SetDisplayRoot() is called mus wires up the window appropriately.

The expectation is ash transitions to observing newly added displays
using another mechanism and then tells mus about it.

BUG=708287
TEST=covered by tests
R=erg@chromium.org
==========

[sky, 2017-04-07 21:50:03]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[sky, 2017-04-07 21:50:18]

+tsepez for mojom

[Tom Sepez, 2017-04-07 21:58:17]

Refresh my memory, we are using unguessable IDs here, so we don't worry about
the usual fake ID shenanigans, right?

[sky, 2017-04-07 22:13:15]

The window id is scoped to the client (the server internally has an id too,
but it's not exposed to the client). OTOH the display id is the de facto
display id, we don't try to hide it. This function is scoped to the window
manager connection.

On Fri, Apr 7, 2017 at 2:58 PM, <tsepez@chromium.org> wrote:

> Refresh my memory, we are using unguessable IDs here, so we don't worry
> about
> the usual fake ID shenanigans, right?
>
> https://codereview.chromium.org/2804403002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-04-07 22:29:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:29:58]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2017-04-07 23:00:05]

lgtm after talking irl

[Tom Sepez, 2017-04-07 23:10:26]

lgtm

[sky, 2017-04-07 23:16:55]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:17:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 00:23:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491607015140030,
"parent_rev": "33760305c05d31db8e2e7ec3c51fb6ed37c975df", "commit_rev":
"bb4b4de1b5a2b99c62e71b93f6c157e8290e3c3b"}

[commit-bot: I haz the power, 2017-04-08 00:24:50]

Description was changed from

==========
Adds ability for WindowManager to create display roots

Prior to this patch mus would automatically create a Window for
each display and tell the WindowManager about it. This patch allows
the WindowManager to control this behavior so that if the
windowmanager wants to create the windows it can. In the new mode mus
still creates a window for the display, but it doesn't tell the
client. The expectation is the client eventually calls
SetDisplayRoot() with the client supplied window. When
SetDisplayRoot() is called mus wires up the window appropriately.

The expectation is ash transitions to observing newly added displays
using another mechanism and then tells mus about it.

BUG=708287
TEST=covered by tests
R=erg@chromium.org
==========

to

==========
Adds ability for WindowManager to create display roots

Prior to this patch mus would automatically create a Window for
each display and tell the WindowManager about it. This patch allows
the WindowManager to control this behavior so that if the
windowmanager wants to create the windows it can. In the new mode mus
still creates a window for the display, but it doesn't tell the
client. The expectation is the client eventually calls
SetDisplayRoot() with the client supplied window. When
SetDisplayRoot() is called mus wires up the window appropriately.

The expectation is ash transitions to observing newly added displays
using another mechanism and then tells mus about it.

BUG=708287
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2804403002
Cr-Commit-Position: refs/heads/master@{#463070}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb4b4de1b5a2b99c62e71b93f6c1...
==========

[commit-bot: I haz the power, 2017-04-08 00:24:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb4b4de1b5a2b99c62e71b93f6c1...