Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2804303004: Revert of OOPIF: Enable TabAndMouseFocusNavigation. (Closed)

Created:
3 years, 8 months ago by Charlie Reis
Modified:
3 years, 8 months ago
Reviewers:
avallee, alexmos, dcheng
CC:
chromium-reviews, blink-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of OOPIF: Enable TabAndMouseFocusNavigation. (patchset #8 id:140001 of https://codereview.chromium.org/2796533002/ ) Reason for revert: Test is flaky on Linux Tests bot: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/54519 Original issue's description: > OOPIF: Enable TabAndMouseFocusNavigation. > > When advancing focus into an iframe, allow the frame to focus itself > after deciding which element will be focused. This prevents sending a > focus event to the previous element in that frame only to blur it > immediately. Non-oopifs simply fire a focus event to the new element, > the previously focused element in that frame received a blur event when > another frame was focused. > > The test ensures a consistent state when mixing tab and clicking > navigation. In specific cases, focus would early out when the element to > advance to was previously focused, and never cleared when the mouse is > clicked in another frame. > > BUG=702330 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2796533002 > Cr-Commit-Position: refs/heads/master@{#463006} > Committed: https://chromium.googlesource.com/chromium/src/+/6a539b43629daa2a49d5603fea5ade7d48d31dd2 TBR=alexmos@chromium.org,dcheng@chromium.org,avallee@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702330 Review-Url: https://codereview.chromium.org/2804303004 Cr-Commit-Position: refs/heads/master@{#463071} Committed: https://chromium.googlesource.com/chromium/src/+/3b7e3fac6988ecb6dd1d2465aee41e473724c9d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -44 lines) Patch
M chrome/browser/site_per_process_interactive_browsertest.cc View 3 chunks +13 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 3 chunks +8 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Charlie Reis
Created Revert of OOPIF: Enable TabAndMouseFocusNavigation.
3 years, 8 months ago (2017-04-08 00:21:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804303004/1
3 years, 8 months ago (2017-04-08 00:22:11 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 00:27:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b7e3fac6988ecb6dd1d2465aee4...

Powered by Google App Engine
This is Rietveld 408576698