tools/metrics/histograms/histograms.xml - Issue 2804283003: [LargeIconService] Report size of the downloaded favicon to UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2804283003: [LargeIconService] Report size of the downloaded favicon to UMA (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 0fddafe46410e387d6a04d3532f021328def2724..c8603ee709b7c86b1181a8d3e4a217fd80c3bf33 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -20408,6 +20408,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Favicons.LargeIconService.DownloadedSize">

Ilya Sherman 2017/04/07 19:26:47 nit: Please add a units attribute.

Ilya Sherman 2017/04/07 19:26:47 Optional nit: Perhaps name this "DownloadedSize.Wi

jkrcal 2017/04/11 19:25:37 Since favicons are square, I find having "Width" i

jkrcal 2017/04/11 19:25:37 Done.

+ <owner>jkrcal@chromium.org</owner>

+ <summary>

+ Records the size (concretely the width) in pixel of the favicon downloaded

+ from Google favicon server (size 0 denotes that download has failed).

+ </summary>

+</histogram>

<histogram name="FileBrowser.CloudImport.UserAction"

enum="CloudImportUserAction">

<owner>smckay@google.com</owner>