Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2804283003: [LargeIconService] Report size of the downloaded favicon to UMA (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
pkotwicz, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LargeIconService] Report size of the downloaded favicon to UMA This CL adds UMA metrics for sizes of favicons downloaded from google favicon server. BUG=709498 Review-Url: https://codereview.chromium.org/2804283003 Cr-Commit-Position: refs/heads/master@{#463726} Committed: https://chromium.googlesource.com/chromium/src/+/b8a55f4294d92eeb88331c93dea8503bc6c2945e

Patch Set 1 #

Total comments: 6

Patch Set 2 : Ilya's comments #

Patch Set 3 : Fix the unit-tests and rebase #

Patch Set 4 : Fix the unit-tests #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M components/favicon/core/large_icon_service.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M components/favicon/core/large_icon_service_unittest.cc View 1 2 3 7 chunks +15 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (21 generated)
jkrcal
Peter, could you PTAL? Ilya, could you PTAL at histograms.xml?
3 years, 8 months ago (2017-04-07 16:15:03 UTC) #2
pkotwicz
LGTM
3 years, 8 months ago (2017-04-07 17:06:59 UTC) #7
Ilya Sherman
Metrics LGTM % nits. https://codereview.chromium.org/2804283003/diff/1/components/favicon/core/large_icon_service.cc File components/favicon/core/large_icon_service.cc (right): https://codereview.chromium.org/2804283003/diff/1/components/favicon/core/large_icon_service.cc#newcode237 components/favicon/core/large_icon_service.cc:237: image.Width()); nit: Histogram macros expand ...
3 years, 8 months ago (2017-04-07 19:26:47 UTC) #8
Ilya Sherman
Though, I'm a bit curious: If this metric is just looking at Google-served favicons, could ...
3 years, 8 months ago (2017-04-07 19:27:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804283003/60001
3 years, 8 months ago (2017-04-11 19:20:32 UTC) #24
jkrcal
Thanks! As regards your question: The server (go/favicon-pdd) is not collecting any logs at the ...
3 years, 8 months ago (2017-04-11 19:25:37 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 19:35:37 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b8a55f4294d92eeb88331c93dea8...

Powered by Google App Engine
This is Rietveld 408576698