Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2804213002: Fail even in release mode when under-invalidation is being checked (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fail even in release mode when under-invalidation is being checked. TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2804213002 Cr-Commit-Position: refs/heads/master@{#462807} Committed: https://chromium.googlesource.com/chromium/src/+/67161fd023615beeb90c01c878220b5485cd057c

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
foolip
lgtm
3 years, 8 months ago (2017-04-07 05:50:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804213002/20001
3 years, 8 months ago (2017-04-07 05:51:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/417299)
3 years, 8 months ago (2017-04-07 07:37:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804213002/20001
3 years, 8 months ago (2017-04-07 07:42:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804213002/20001
3 years, 8 months ago (2017-04-07 08:12:44 UTC) #19
foolip
Some red bots, but I checked that the failures were due to other things I'm ...
3 years, 8 months ago (2017-04-07 08:13:03 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 08:19:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67161fd023615beeb90c01c87822...

Powered by Google App Engine
This is Rietveld 408576698