Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2804183002: Revert of Media Remoting: End to end integration tests. (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, apacible+watch_chromium.org, erickung+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Media Remoting: End to end integration tests. (patchset #4 id:120001 of https://codereview.chromium.org/2692593002/ ) Reason for revert: Findit identified CL at revision 462739 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYwZDRlMGE2M2ViM2YyYmUyNmFjYTEyODFiZTI5YzY0YjBmNWM2NzAM Original issue's description: > Media Remoting: End to end integration tests. > > Add end to end integration tests for Media Remoting. Refactors > PipelineIntegrationTest to test both media and media remoting pipeline. > Re-use current tests. No new tests are added in this CL. > > BUG=684065 > > Review-Url: https://codereview.chromium.org/2692593002 > Cr-Commit-Position: refs/heads/master@{#462739} > Committed: https://chromium.googlesource.com/chromium/src/+/60d4e0a63eb3f2be26aca1281be29c64b0f5c670 TBR=miu@chromium.org,sandersd@chromium.org,xjz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684065 Review-Url: https://codereview.chromium.org/2804183002 Cr-Commit-Position: refs/heads/master@{#462744} Committed: https://chromium.googlesource.com/chromium/src/+/b1b017627acf79bdb62b1fa273d45e87fed29b5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -2208 lines) Patch
M media/remoting/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D media/remoting/end2end_test_renderer.h View 1 chunk +0 lines, -71 lines 0 comments Download
D media/remoting/end2end_test_renderer.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D media/remoting/receiver.h View 1 chunk +0 lines, -88 lines 0 comments Download
D media/remoting/receiver.cc View 1 chunk +0 lines, -304 lines 0 comments Download
D media/remoting/stream_provider.h View 1 chunk +0 lines, -69 lines 0 comments Download
D media/remoting/stream_provider.cc View 1 chunk +0 lines, -485 lines 0 comments Download
M media/test/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 46 chunks +703 lines, -802 lines 0 comments Download
M media/test/pipeline_integration_test_base.h View 3 chunks +59 lines, -83 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 6 chunks +6 lines, -76 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
findit-for-me
Created Revert of Media Remoting: End to end integration tests.
3 years, 8 months ago (2017-04-07 02:43:41 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-07 02:43:42 UTC) #3
foolip
lgtm
3 years, 8 months ago (2017-04-07 04:14:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804183002/1
3 years, 8 months ago (2017-04-07 04:14:52 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 04:18:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1b017627acf79bdb62b1fa273d4...

Powered by Google App Engine
This is Rietveld 408576698