Fix buildbot recipe for android_n5x_swarming_dbg

Fix buildbot recipe for android_n5x_swarming_dbg

The compile targets in the bot configuration is for GYP, and don't 
seem to be required any more. Set them to the real target they
depend on.

Before this patch, the build failed at step 14. analyze. Now it 
passes (actual tests fail but they are to be looked into separately).

Review-Url: https://codereview.chromium.org/2804163002
Cr-Commit-Position: refs/heads/master@{#463864}
Committed: https://chromium.googlesource.com/chromium/src/+/9b0d77b15fee21af7508c5dbce762a82599b2f3e

[Jinsuk Kim, 2017-04-07 03:16:06]

Description was changed from

==========
Fix buildbot recipe for android_n5x_swarming_dbg
==========

to

==========
Fix buildbot recipe for android_n5x_swarming_dbg

The compile targets in the bot configuration is for GYP, and don't 
seem to be required any more. Set them to the real target they
depend on.

Before this patch, the build failed at step 14. analyze. Now it 
passes (actual tests fail but they are to be looked into separately).
==========

[Jinsuk Kim, 2017-04-07 03:16:57]

jinsukkim@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Jinsuk Kim, 2017-04-07 03:16:58]

The error message at the step analyze is like following:

analyze input:
{
  "additional_compile_targets": [
    "dump_syms", 
    "microdump_stackwalk"
  ], 
  "files": [
   
"chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java",

    "content/browser/BUILD.gn", 
    "content/browser/android/browser_jni_registrar.cc", 
    "content/browser/android/content_view_core_impl.cc", 
    "content/browser/android/content_view_core_impl.h", 
    "content/browser/android/ime_adapter_android.cc", 
    "content/browser/android/ime_adapter_android.h", 
    "content/browser/android/render_process_connector.cc", 
    "content/browser/android/render_process_connector.h", 
    "content/browser/android/selection_popup_controller.cc", 
    "content/browser/android/selection_popup_controller.h", 
    "content/browser/renderer_host/render_widget_host_view_android.cc", 
    "content/browser/renderer_host/render_widget_host_view_android.h", 
    "content/public/android/BUILD.gn", 
   
"content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java",

   
"content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java",

   
"content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java"
  ], 
  "test_targets": [
    "android_webview_test_apk", 
    "android_webview_unittests_apk_run", 
    "base_unittests_apk_run", 
    "blink_heap_unittests_apk_run", 
    "breakpad_unittests_deps", 
    "capture_unittests_apk_run", 
    "cc_unittests_apk_run", 
    "chrome_public_test_apk", 
    "chrome_sync_shell_test_apk", 
    "components_browsertests_apk_run", 
    "components_unittests_apk_run", 
    "content_browsertests_apk_run", 
    "content_shell_test_apk", 
    "content_unittests_apk_run", 
    "device_unittests_apk_run", 
    "events_unittests_apk_run", 
    "gfx_unittests_apk_run", 
    "gl_tests_apk_run", 
    "gl_unittests_apk_run", 
    "gpu_ipc_service_unittests_apk_run", 
    "gpu_unittests_apk_run", 
    "ipc_tests_apk_run", 
    "media_unittests_apk_run", 
    "net_unittests_apk_run", 
    "sandbox_linux_unittests_deps", 
    "sql_unittests_apk_run", 
    "storage_unittests_apk_run", 
    "system_webview_apk", 
    "ui_android_unittests_apk_run", 
    "ui_base_unittests_apk_run", 
    "ui_touch_selection_unittests_apk_run", 
    "unit_tests_apk_run", 
    "vr_shell_unittests_apk_run"
  ]
}


# To recreate the file passed to argv[0] (input_path):
% cat > /tmp/tmpZ2hTB6.json <<EOF
{"additional_compile_targets": ["dump_syms", "microdump_stackwalk"], "files":
["chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java",
"content/browser/BUILD.gn", "content/browser/android/browser_jni_registrar.cc",
"content/browser/android/content_view_core_impl.cc",
"content/browser/android/content_view_core_impl.h",
"content/browser/android/ime_adapter_android.cc",
"content/browser/android/ime_adapter_android.h",
"content/browser/android/render_process_connector.cc",
"content/browser/android/render_process_connector.h",
"content/browser/android/selection_popup_controller.cc",
"content/browser/android/selection_popup_controller.h",
"content/browser/renderer_host/render_widget_host_view_android.cc",
"content/browser/renderer_host/render_widget_host_view_android.h",
"content/public/android/BUILD.gn",
"content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java",
"content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java",
"content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java"],
"test_targets": ["android_webview_test_apk",
"android_webview_unittests_apk_run", "base_unittests_apk_run",
"blink_heap_unittests_apk_run", "breakpad_unittests_deps",
"capture_unittests_apk_run", "cc_unittests_apk_run", "chrome_public_test_apk",
"chrome_sync_shell_test_apk", "components_browsertests_apk_run",
"components_unittests_apk_run", "content_browsertests_apk_run",
"content_shell_test_apk", "content_unittests_apk_run",
"device_unittests_apk_run", "events_unittests_apk_run", "gfx_unittests_apk_run",
"gl_tests_apk_run", "gl_unittests_apk_run", "gpu_ipc_service_unittests_apk_run",
"gpu_unittests_apk_run", "ipc_tests_apk_run", "media_unittests_apk_run",
"net_unittests_apk_run", "sandbox_linux_unittests_deps",
"sql_unittests_apk_run", "storage_unittests_apk_run", "system_webview_apk",
"ui_android_unittests_apk_run", "ui_base_unittests_apk_run",
"ui_touch_selection_unittests_apk_run", "unit_tests_apk_run",
"vr_shell_unittests_apk_run"]}
EOF
%

Traceback (most recent call last):
  File "/b/c/b/android_n5x_swarming_dbg/src/tools/mb/mb.py", line 61, in Main
    ret = self.args.func()
  File "/b/c/b/android_n5x_swarming_dbg/src/tools/mb/mb.py", line 263, in
CmdAnalyze
    return self.RunGNAnalyze(vals)
  File "/b/c/b/android_n5x_swarming_dbg/src/tools/mb/mb.py", line 1300, in
RunGNAnalyze
    raise MBErr(err)
MBErr: target "breakpad_unittests_deps" not found in
//testing/buildbot/gn_isolate_map.pyl
target "sandbox_linux_unittests_deps" not found in
//testing/buildbot/gn_isolate_map.pyl

step returned non-zero exit code: 1

[Jinsuk Kim, 2017-04-07 05:07:22]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 05:07:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:05:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Paweł Hajdan Jr., 2017-04-07 16:10:26]

phajdan.jr@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Paweł Hajdan Jr., 2017-04-07 16:10:26]

The analyze point is inconclusive: "Analyze disabled: matched exclusion"

Adding jbudorick@ .

[jbudorick, 2017-04-11 02:39:16]

lgtm w/ nit

https://codereview.chromium.org/2804163002/diff/1/testing/buildbot/chromium.a...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2804163002/diff/1/testing/buildbot/chromium.a...
testing/buildbot/chromium.android.json:2643: "override_compile_targets": [
You should be able to remove the override_compile_targets section entirely both
here and below.

[Jinsuk Kim, 2017-04-11 05:05:20]

https://codereview.chromium.org/2804163002/diff/1/testing/buildbot/chromium.a...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2804163002/diff/1/testing/buildbot/chromium.a...
testing/buildbot/chromium.android.json:2643: "override_compile_targets": [
On 2017/04/11 02:39:15, jbudorick wrote:
> You should be able to remove the override_compile_targets section entirely
both
> here and below.

Done.

[Jinsuk Kim, 2017-04-11 05:05:27]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 05:05:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 06:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 06:36:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jinsuk Kim, 2017-04-12 00:23:57]

The CQ bit was checked by jinsukkim@chromium.org

[Jinsuk Kim, 2017-04-12 00:23:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2804163002/#ps20001
(title: "remove override compile targets")

[commit-bot: I haz the power, 2017-04-12 00:24:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 00:57:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491956637395210,
"parent_rev": "23724703cfbba977e4628436698c59bdba5c2b05", "commit_rev":
"9b0d77b15fee21af7508c5dbce762a82599b2f3e"}

[commit-bot: I haz the power, 2017-04-12 00:58:39]

Description was changed from

==========
Fix buildbot recipe for android_n5x_swarming_dbg

The compile targets in the bot configuration is for GYP, and don't 
seem to be required any more. Set them to the real target they
depend on.

Before this patch, the build failed at step 14. analyze. Now it 
passes (actual tests fail but they are to be looked into separately).
==========

to

==========
Fix buildbot recipe for android_n5x_swarming_dbg

The compile targets in the bot configuration is for GYP, and don't 
seem to be required any more. Set them to the real target they
depend on.

Before this patch, the build failed at step 14. analyze. Now it 
passes (actual tests fail but they are to be looked into separately).

Review-Url: https://codereview.chromium.org/2804163002
Cr-Commit-Position: refs/heads/master@{#463864}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b0d77b15fee21af7508c5dbce76...
==========

[commit-bot: I haz the power, 2017-04-12 00:58:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b0d77b15fee21af7508c5dbce76...