Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2804103002: Throw when testharness::done() is called by layout test code (Closed)

Created:
3 years, 8 months ago by hongchan
Modified:
3 years, 8 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw when testharness::done() is called by layout test code This CL wraps done() method in the global scope, which is defined by testharness.js to prevent a test from finishing prematurely. 2 layout tests are found from this check and fixed accordingly. BUG=708817 TESTS= webaudio/AudioParam/audioparam-update-value-attribute.html webaudio/DynamicsCompressor/dynamicscompressor-basic.html Review-Url: https://codereview.chromium.org/2804103002 Cr-Commit-Position: refs/heads/master@{#462685} Committed: https://chromium.googlesource.com/chromium/src/+/897d20df0777854e91b4afab0923e917cd06640a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-basic.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hongchan
PTAL. Confirmed all tests are passing locally.
3 years, 8 months ago (2017-04-06 19:38:24 UTC) #2
Raymond Toy
lgtm
3 years, 8 months ago (2017-04-06 20:02:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804103002/1
3 years, 8 months ago (2017-04-06 20:34:33 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:41:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/897d20df0777854e91b4afab0923...

Powered by Google App Engine
This is Rietveld 408576698