Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2804053002: [Devtools] Move request blocking out of experiments (Closed)

Created:
3 years, 8 months ago by allada
Modified:
3 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Move request blocking out of experiments This patch releases network blocking. R=dgozman,pfeldman BUG=709108 Review-Url: https://codereview.chromium.org/2804053002 Cr-Commit-Position: refs/heads/master@{#463027} Committed: https://chromium.googlesource.com/chromium/src/+/cf4a58cc16ab500cbea5bd0fae723a59fed12f4e

Patch Set 1 #

Total comments: 4

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
allada
PTL
3 years, 8 months ago (2017-04-06 17:54:07 UTC) #1
dgozman
https://codereview.chromium.org/2804053002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2804053002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1121 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1121: if (request) { // Disabled until ready. Wrong comment. ...
3 years, 8 months ago (2017-04-06 19:28:16 UTC) #2
allada
PTaL https://codereview.chromium.org/2804053002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/2804053002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js#newcode1121 third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1121: if (request) { // Disabled until ready. On ...
3 years, 8 months ago (2017-04-07 18:21:26 UTC) #3
pfeldman
lgtm
3 years, 8 months ago (2017-04-07 18:27:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804053002/20001
3 years, 8 months ago (2017-04-07 21:01:04 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 22:50:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf4a58cc16ab500cbea5bd0fae72...

Powered by Google App Engine
This is Rietveld 408576698