Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2804033004: Refresh Public Suffic List to the latest version (Closed)

Created:
3 years, 8 months ago by Ryan Sleevi
Modified:
3 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffic List to the latest version This updates from revision 1b9ceb762bda9cba75066b8be3c73aed634fd82f (2017-02-23) to revision 387c30de530e765666ee7af4fd03d2fec17b5c74 (2017-04-07) R=pkasting@chromium.org BUG=695364 Review-Url: https://codereview.chromium.org/2804033004 Cr-Commit-Position: refs/heads/master@{#463107} Committed: https://chromium.googlesource.com/chromium/src/+/6a620bf4c6e8079cbe1a40cb3ebe117255b6ffc7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -30 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 22 chunks +61 lines, -24 lines 1 comment Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 28 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ryan Sleevi
3 years, 8 months ago (2017-04-07 19:28:46 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/2804033004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/2804033004/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode11267 net/base/registry_controlled_domains/effective_tld_names.dat:11267: map.fastlylb.net Not really sure I understand how fastly1b.net ...
3 years, 8 months ago (2017-04-08 00:41:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804033004/1
3 years, 8 months ago (2017-04-08 01:03:04 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 02:13:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a620bf4c6e8079cbe1a40cb3ebe...

Powered by Google App Engine
This is Rietveld 408576698