Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
index d99ef016ddbc9e8e2a939bba8b06591d1b362054..a751dcaf215f999bbdb8c9780c23fd51f248dc75 100644
--- a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
@@ -63,7 +63,7 @@ TEST(ServiceWorkerResponseTest, FromFetchResponseData) {
fetch_response_data->SetURLList(url_list);
Response* response =
Response::Create(&page->GetDocument(), fetch_response_data);
- ASSERT(response);
+ DCHECK(response);
EXPECT_EQ(url, response->url());
}
@@ -72,7 +72,7 @@ TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse) {
std::unique_ptr<WebServiceWorkerResponse> web_response =
CreateTestWebServiceWorkerResponse();
Response* response = Response::Create(scope.GetScriptState(), *web_response);
- ASSERT(response);
+ DCHECK(response);
ASSERT_EQ(1u, web_response->UrlList().size());
EXPECT_EQ(web_response->UrlList()[0], response->url());
EXPECT_EQ(web_response->Status(), response->status());
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698