Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Response.h" 5 #include "modules/fetch/Response.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "bindings/core/v8/ScriptState.h" 9 #include "bindings/core/v8/ScriptState.h"
10 #include "bindings/core/v8/V8BindingForTesting.h" 10 #include "bindings/core/v8/V8BindingForTesting.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 std::unique_ptr<DummyPageHolder> page = 56 std::unique_ptr<DummyPageHolder> page =
57 DummyPageHolder::Create(IntSize(1, 1)); 57 DummyPageHolder::Create(IntSize(1, 1));
58 const KURL url(kParsedURLString, "http://www.response.com"); 58 const KURL url(kParsedURLString, "http://www.response.com");
59 59
60 FetchResponseData* fetch_response_data = FetchResponseData::Create(); 60 FetchResponseData* fetch_response_data = FetchResponseData::Create();
61 Vector<KURL> url_list; 61 Vector<KURL> url_list;
62 url_list.push_back(url); 62 url_list.push_back(url);
63 fetch_response_data->SetURLList(url_list); 63 fetch_response_data->SetURLList(url_list);
64 Response* response = 64 Response* response =
65 Response::Create(&page->GetDocument(), fetch_response_data); 65 Response::Create(&page->GetDocument(), fetch_response_data);
66 ASSERT(response); 66 DCHECK(response);
67 EXPECT_EQ(url, response->url()); 67 EXPECT_EQ(url, response->url());
68 } 68 }
69 69
70 TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse) { 70 TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse) {
71 V8TestingScope scope; 71 V8TestingScope scope;
72 std::unique_ptr<WebServiceWorkerResponse> web_response = 72 std::unique_ptr<WebServiceWorkerResponse> web_response =
73 CreateTestWebServiceWorkerResponse(); 73 CreateTestWebServiceWorkerResponse();
74 Response* response = Response::Create(scope.GetScriptState(), *web_response); 74 Response* response = Response::Create(scope.GetScriptState(), *web_response);
75 ASSERT(response); 75 DCHECK(response);
76 ASSERT_EQ(1u, web_response->UrlList().size()); 76 ASSERT_EQ(1u, web_response->UrlList().size());
77 EXPECT_EQ(web_response->UrlList()[0], response->url()); 77 EXPECT_EQ(web_response->UrlList()[0], response->url());
78 EXPECT_EQ(web_response->Status(), response->status()); 78 EXPECT_EQ(web_response->Status(), response->status());
79 EXPECT_STREQ(web_response->StatusText().Utf8().c_str(), 79 EXPECT_STREQ(web_response->StatusText().Utf8().c_str(),
80 response->statusText().Utf8().Data()); 80 response->statusText().Utf8().Data());
81 81
82 Headers* response_headers = response->headers(); 82 Headers* response_headers = response->headers();
83 83
84 WebVector<WebString> keys = web_response->GetHeaderKeys(); 84 WebVector<WebString> keys = web_response->GetHeaderKeys();
85 EXPECT_EQ(keys.size(), response_headers->HeaderList()->size()); 85 EXPECT_EQ(keys.size(), response_headers->HeaderList()->size());
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 311
312 response->InternalBodyBuffer()->StartLoading( 312 response->InternalBodyBuffer()->StartLoading(
313 FetchDataLoader::CreateLoaderAsString(), client1); 313 FetchDataLoader::CreateLoaderAsString(), client1);
314 cloned_response->InternalBodyBuffer()->StartLoading( 314 cloned_response->InternalBodyBuffer()->StartLoading(
315 FetchDataLoader::CreateLoaderAsString(), client2); 315 FetchDataLoader::CreateLoaderAsString(), client2);
316 blink::testing::RunPendingTasks(); 316 blink::testing::RunPendingTasks();
317 } 317 }
318 318
319 } // namespace 319 } // namespace
320 } // namespace blink 320 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Response.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698