Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
index 6e415324d38b1336a661443afb9436f33c4a32f1..f91e11fdfced67796fcb74a4d96b064b3b371cad 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
@@ -193,9 +193,9 @@ class FetchManager::Loader final
}
void DidGetReadable() override {
- ASSERT(reader_);
- ASSERT(loader_);
- ASSERT(response_);
+ DCHECK(reader_);
+ DCHECK(loader_);
+ DCHECK(response_);
WebDataConsumerHandle::Result r = WebDataConsumerHandle::kOk;
while (r == WebDataConsumerHandle::kOk) {
@@ -309,7 +309,7 @@ FetchManager::Loader::Loader(ExecutionContext* execution_context,
}
FetchManager::Loader::~Loader() {
- ASSERT(!loader_);
+ DCHECK(!loader_);
}
DEFINE_TRACE(FetchManager::Loader) {
@@ -329,7 +329,7 @@ void FetchManager::Loader::DidReceiveResponse(
unsigned long,
const ResourceResponse& response,
std::unique_ptr<WebDataConsumerHandle> handle) {
- ASSERT(handle);
+ DCHECK(handle);
// TODO(horo): This check could be false when we will use the response url
// in service worker responses. (crbug.com/553535)
DCHECK(response.Url() == url_list_.back());
@@ -493,7 +493,7 @@ void FetchManager::Loader::DidReceiveResponse(
resolver_->Resolve(r);
resolver_.Clear();
} else {
- ASSERT(!integrity_verifier_);
+ DCHECK(!integrity_verifier_);
integrity_verifier_ =
new SRIVerifier(std::move(handle), sri_consumer, r, this,
request_->Integrity(), response.Url());
@@ -543,7 +543,7 @@ Document* FetchManager::Loader::GetDocument() const {
}
void FetchManager::Loader::LoadSucceeded() {
- ASSERT(!failed_);
+ DCHECK(!failed_);
finished_ = true;
@@ -700,7 +700,7 @@ void FetchManager::Loader::PerformNetworkError(const String& message) {
void FetchManager::Loader::PerformHTTPFetch(bool cors_flag,
bool cors_preflight_flag) {
- ASSERT(SchemeRegistry::ShouldTreatURLSchemeAsSupportingFetchAPI(
+ DCHECK(SchemeRegistry::ShouldTreatURLSchemeAsSupportingFetchAPI(
request_->Url().Protocol()) ||
(request_->Url().ProtocolIs("blob") && !cors_flag &&
!cors_preflight_flag));
@@ -839,7 +839,7 @@ void FetchManager::Loader::PerformHTTPFetch(bool cors_flag,
// 'same-origin' mode.
// - We reject non-GET method.
void FetchManager::Loader::PerformDataFetch() {
- ASSERT(request_->Url().ProtocolIsData());
+ DCHECK(request_->Url().ProtocolIsData());
ResourceRequest request(request_->Url());
request.SetRequestContext(request_->Context());

Powered by Google App Engine
This is Rietveld 408576698