Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
index 506ba6b2d2340eb14ddee1bb8c40f5d8f9437a84..a6021ba9d5b4ac412ecc4d1d14afb2da29e181ce 100644
--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
@@ -111,24 +111,24 @@ class DataConsumerHandleTestUtil {
void RegisterThreadHolder(ThreadHolder* holder) {
MutexLocker locker(holder_mutex_);
- ASSERT(!holder_);
+ DCHECK(!holder_);
holder_ = holder;
}
void UnregisterThreadHolder() {
MutexLocker locker(holder_mutex_);
- ASSERT(holder_);
+ DCHECK(holder_);
holder_ = nullptr;
}
void PostTaskToReadingThread(const WebTraceLocation& location,
std::unique_ptr<CrossThreadClosure> task) {
MutexLocker locker(holder_mutex_);
- ASSERT(holder_);
+ DCHECK(holder_);
holder_->ReadingThread()->PostTask(location, std::move(task));
}
void PostTaskToUpdatingThread(const WebTraceLocation& location,
std::unique_ptr<CrossThreadClosure> task) {
MutexLocker locker(holder_mutex_);
- ASSERT(holder_);
+ DCHECK(holder_);
holder_->UpdatingThread()->PostTask(location, std::move(task));
}
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698