Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
index 14dffef5117c19457c7ff5bd3fd52db946a6efac..0ab6b661d746324c4eae6bef8631c80be39c57db 100644
--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
@@ -131,8 +131,8 @@ ScriptValue BodyStreamBuffer::Stream() {
PassRefPtr<BlobDataHandle> BodyStreamBuffer::DrainAsBlobDataHandle(
BytesConsumer::BlobSizePolicy policy) {
- ASSERT(!IsStreamLocked());
- ASSERT(!IsStreamDisturbed());
+ DCHECK(!IsStreamLocked());
+ DCHECK(!IsStreamDisturbed());
if (IsStreamClosed() || IsStreamErrored())
return nullptr;
@@ -149,8 +149,8 @@ PassRefPtr<BlobDataHandle> BodyStreamBuffer::DrainAsBlobDataHandle(
}
PassRefPtr<EncodedFormData> BodyStreamBuffer::DrainAsFormData() {
- ASSERT(!IsStreamLocked());
- ASSERT(!IsStreamDisturbed());
+ DCHECK(!IsStreamLocked());
+ DCHECK(!IsStreamDisturbed());
if (IsStreamClosed() || IsStreamErrored())
return nullptr;
@@ -167,8 +167,8 @@ PassRefPtr<EncodedFormData> BodyStreamBuffer::DrainAsFormData() {
void BodyStreamBuffer::StartLoading(FetchDataLoader* loader,
FetchDataLoader::Client* client) {
- ASSERT(!loader_);
- ASSERT(script_state_->ContextIsValid());
+ DCHECK(!loader_);
+ DCHECK(script_state_->ContextIsValid());
loader_ = loader;
loader->Start(ReleaseHandle(),
new LoaderClient(ExecutionContext::From(script_state_.Get()),
@@ -199,7 +199,7 @@ void BodyStreamBuffer::Tee(BodyStreamBuffer** branch1,
}
ScriptPromise BodyStreamBuffer::pull(ScriptState* script_state) {
- ASSERT(script_state == script_state_.Get());
+ DCHECK_EQ(script_state, script_state_.Get());
if (stream_needs_more_)
return ScriptPromise::CastUndefined(script_state);
stream_needs_more_ = true;
@@ -209,7 +209,7 @@ ScriptPromise BodyStreamBuffer::pull(ScriptState* script_state) {
ScriptPromise BodyStreamBuffer::Cancel(ScriptState* script_state,
ScriptValue reason) {
- ASSERT(script_state == script_state_.Get());
+ DCHECK_EQ(script_state, script_state_.Get());
Close();
return ScriptPromise::CastUndefined(script_state);
}
@@ -346,7 +346,7 @@ void BodyStreamBuffer::ProcessData() {
}
void BodyStreamBuffer::EndLoading() {
- ASSERT(loader_);
+ DCHECK(loader_);
loader_ = nullptr;
}
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Body.cpp ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698