Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: third_party/WebKit/Source/modules/fetch/Headers.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Headers.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Headers.cpp b/third_party/WebKit/Source/modules/fetch/Headers.cpp
index 0b2b43392e82096c0f1a494c59ff116825db99d5..05ef64aa82bdfcc4057818929168ac0b19f0d135 100644
--- a/third_party/WebKit/Source/modules/fetch/Headers.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Headers.cpp
@@ -250,7 +250,7 @@ void Headers::set(const String& name,
}
void Headers::fillWith(const Headers* object, ExceptionState& exceptionState) {
- ASSERT(m_headerList->size() == 0);
+ DCHECK(m_headerList->size() == 0);
tkent 2017/04/08 02:29:54 Use DCHECK_EQ.
// "To fill a Headers object (|this|) with a given object (|object|), run
// these steps:"
// "1. If |object| is a Headers object, copy its header list as
@@ -267,7 +267,7 @@ void Headers::fillWith(const Headers* object, ExceptionState& exceptionState) {
void Headers::fillWith(const Vector<Vector<String>>& object,
ExceptionState& exceptionState) {
- ASSERT(!m_headerList->size());
+ DCHECK(!m_headerList->size());
// "2. Otherwise, if |object| is a sequence, then for each |header| in
// |object|, run these substeps:
// 1. If |header| does not contain exactly two items, throw a
@@ -287,7 +287,7 @@ void Headers::fillWith(const Vector<Vector<String>>& object,
void Headers::fillWith(const Dictionary& object,
ExceptionState& exceptionState) {
- ASSERT(!m_headerList->size());
+ DCHECK(!m_headerList->size());
const Vector<String>& keys = object.getPropertyNames(exceptionState);
if (exceptionState.hadException() || !keys.size())
return;

Powered by Google App Engine
This is Rietveld 408576698