Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp b/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
index 6509cae9ddff567538111d2e5515eae8d6da95d5..06a58d9ed946433cb25fb6e9097cea3d113d79f2 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
@@ -220,15 +220,15 @@ FetchResponseData* FetchResponseData::clone(ScriptState* scriptState) {
switch (m_type) {
case BasicType:
case CORSType:
- ASSERT(m_internalResponse);
- ASSERT(m_buffer == m_internalResponse->m_buffer);
- ASSERT(m_internalResponse->m_type == DefaultType);
+ DCHECK(m_internalResponse);
+ DCHECK(m_buffer == m_internalResponse->m_buffer);
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
+ DCHECK(m_internalResponse->m_type == DefaultType);
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
newResponse->m_internalResponse = m_internalResponse->clone(scriptState);
m_buffer = m_internalResponse->m_buffer;
newResponse->m_buffer = newResponse->m_internalResponse->m_buffer;
break;
case DefaultType: {
- ASSERT(!m_internalResponse);
+ DCHECK(!m_internalResponse);
if (m_buffer) {
BodyStreamBuffer* new1 = nullptr;
BodyStreamBuffer* new2 = nullptr;
@@ -239,14 +239,14 @@ FetchResponseData* FetchResponseData::clone(ScriptState* scriptState) {
break;
}
case ErrorType:
- ASSERT(!m_internalResponse);
- ASSERT(!m_buffer);
+ DCHECK(!m_internalResponse);
+ DCHECK(!m_buffer);
break;
case OpaqueType:
case OpaqueRedirectType:
- ASSERT(m_internalResponse);
- ASSERT(!m_buffer);
- ASSERT(m_internalResponse->m_type == DefaultType);
+ DCHECK(m_internalResponse);
+ DCHECK(!m_buffer);
+ DCHECK(m_internalResponse->m_type == DefaultType);
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
newResponse->m_internalResponse = m_internalResponse->clone(scriptState);
break;
}
@@ -287,11 +287,11 @@ FetchResponseData::FetchResponseData(Type type,
void FetchResponseData::replaceBodyStreamBuffer(BodyStreamBuffer* buffer) {
if (m_type == BasicType || m_type == CORSType) {
- ASSERT(m_internalResponse);
+ DCHECK(m_internalResponse);
m_internalResponse->m_buffer = buffer;
m_buffer = buffer;
} else if (m_type == DefaultType) {
- ASSERT(!m_internalResponse);
+ DCHECK(!m_internalResponse);
m_buffer = buffer;
}
}

Powered by Google App Engine
This is Rietveld 408576698