Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Response.h" 5 #include "modules/fetch/Response.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 TEST(ServiceWorkerResponseTest, FromFetchResponseData) { 54 TEST(ServiceWorkerResponseTest, FromFetchResponseData) {
55 std::unique_ptr<DummyPageHolder> page = 55 std::unique_ptr<DummyPageHolder> page =
56 DummyPageHolder::create(IntSize(1, 1)); 56 DummyPageHolder::create(IntSize(1, 1));
57 const KURL url(ParsedURLString, "http://www.response.com"); 57 const KURL url(ParsedURLString, "http://www.response.com");
58 58
59 FetchResponseData* fetchResponseData = FetchResponseData::create(); 59 FetchResponseData* fetchResponseData = FetchResponseData::create();
60 Vector<KURL> urlList; 60 Vector<KURL> urlList;
61 urlList.push_back(url); 61 urlList.push_back(url);
62 fetchResponseData->setURLList(urlList); 62 fetchResponseData->setURLList(urlList);
63 Response* response = Response::create(&page->document(), fetchResponseData); 63 Response* response = Response::create(&page->document(), fetchResponseData);
64 ASSERT(response); 64 DCHECK(response);
65 EXPECT_EQ(url, response->url()); 65 EXPECT_EQ(url, response->url());
66 } 66 }
67 67
68 TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse) { 68 TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse) {
69 V8TestingScope scope; 69 V8TestingScope scope;
70 std::unique_ptr<WebServiceWorkerResponse> webResponse = 70 std::unique_ptr<WebServiceWorkerResponse> webResponse =
71 createTestWebServiceWorkerResponse(); 71 createTestWebServiceWorkerResponse();
72 Response* response = Response::create(scope.getScriptState(), *webResponse); 72 Response* response = Response::create(scope.getScriptState(), *webResponse);
73 ASSERT(response); 73 DCHECK(response);
74 ASSERT_EQ(1u, webResponse->urlList().size()); 74 ASSERT_EQ(1u, webResponse->urlList().size());
75 EXPECT_EQ(webResponse->urlList()[0], response->url()); 75 EXPECT_EQ(webResponse->urlList()[0], response->url());
76 EXPECT_EQ(webResponse->status(), response->status()); 76 EXPECT_EQ(webResponse->status(), response->status());
77 EXPECT_STREQ(webResponse->statusText().utf8().c_str(), 77 EXPECT_STREQ(webResponse->statusText().utf8().c_str(),
78 response->statusText().utf8().data()); 78 response->statusText().utf8().data());
79 79
80 Headers* responseHeaders = response->headers(); 80 Headers* responseHeaders = response->headers();
81 81
82 WebVector<WebString> keys = webResponse->getHeaderKeys(); 82 WebVector<WebString> keys = webResponse->getHeaderKeys();
83 EXPECT_EQ(keys.size(), responseHeaders->headerList()->size()); 83 EXPECT_EQ(keys.size(), responseHeaders->headerList()->size());
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 307
308 response->internalBodyBuffer()->startLoading( 308 response->internalBodyBuffer()->startLoading(
309 FetchDataLoader::createLoaderAsString(), client1); 309 FetchDataLoader::createLoaderAsString(), client1);
310 clonedResponse->internalBodyBuffer()->startLoading( 310 clonedResponse->internalBodyBuffer()->startLoading(
311 FetchDataLoader::createLoaderAsString(), client2); 311 FetchDataLoader::createLoaderAsString(), client2);
312 blink::testing::runPendingTasks(); 312 blink::testing::runPendingTasks();
313 } 313 }
314 314
315 } // namespace 315 } // namespace
316 } // namespace blink 316 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698