Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/Response.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Response.h" 5 #include "modules/fetch/Response.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "bindings/core/v8/ExceptionState.h" 9 #include "bindings/core/v8/ExceptionState.h"
10 #include "bindings/core/v8/ScriptState.h" 10 #include "bindings/core/v8/ScriptState.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 } 81 }
82 case WebServiceWorkerResponseTypeOpaque: 82 case WebServiceWorkerResponseTypeOpaque:
83 response = response->createOpaqueFilteredResponse(); 83 response = response->createOpaqueFilteredResponse();
84 break; 84 break;
85 case WebServiceWorkerResponseTypeOpaqueRedirect: 85 case WebServiceWorkerResponseTypeOpaqueRedirect:
86 response = response->createOpaqueRedirectFilteredResponse(); 86 response = response->createOpaqueRedirectFilteredResponse();
87 break; 87 break;
88 case WebServiceWorkerResponseTypeDefault: 88 case WebServiceWorkerResponseTypeDefault:
89 break; 89 break;
90 case WebServiceWorkerResponseTypeError: 90 case WebServiceWorkerResponseTypeError:
91 ASSERT(response->getType() == FetchResponseData::ErrorType); 91 DCHECK(response->getType() == FetchResponseData::ErrorType);
tkent 2017/04/08 02:29:55 Use DCHECK_EQ if it doesn't cause a build failure.
92 break; 92 break;
93 } 93 }
94 94
95 return response; 95 return response;
96 } 96 }
97 97
98 // Checks whether |status| is a null body status. 98 // Checks whether |status| is a null body status.
99 // Spec: https://fetch.spec.whatwg.org/#null-body-status 99 // Spec: https://fetch.spec.whatwg.org/#null-body-status
100 bool isNullBodyStatus(unsigned short status) { 100 bool isNullBodyStatus(unsigned short status) {
101 if (status == 101 || status == 204 || status == 205 || status == 304) 101 if (status == 101 || status == 204 || status == 205 || status == 304)
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 .set(response.As<v8::Object>(), bodyBuffer); 459 .set(response.As<v8::Object>(), bodyBuffer);
460 } 460 }
461 461
462 DEFINE_TRACE(Response) { 462 DEFINE_TRACE(Response) {
463 Body::trace(visitor); 463 Body::trace(visitor);
464 visitor->trace(m_response); 464 visitor->trace(m_response);
465 visitor->trace(m_headers); 465 visitor->trace(m_headers);
466 } 466 }
467 467
468 } // namespace blink 468 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698