Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2614)

Unified Diff: chrome/browser/net/chrome_network_delegate_unittest.cc

Issue 2804023003: Network traffic annotation added to chrome/browser/ unittests. (Closed)
Patch Set: Another missing header added. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate_unittest.cc
diff --git a/chrome/browser/net/chrome_network_delegate_unittest.cc b/chrome/browser/net/chrome_network_delegate_unittest.cc
index 8a08c72d5fb84e79059c66ec6190cad7d9f3ccef..5020876a9048d6d08721e66177a200961fcb9a5f 100644
--- a/chrome/browser/net/chrome_network_delegate_unittest.cc
+++ b/chrome/browser/net/chrome_network_delegate_unittest.cc
@@ -39,6 +39,7 @@
#include "net/base/request_priority.h"
#include "net/http/http_request_headers.h"
#include "net/socket/socket_test_util.h"
+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -73,8 +74,9 @@ std::unique_ptr<net::URLRequest> RequestURL(
socket_factory->AddSocketDataProvider(&response_socket_data_provider);
net::TestDelegate test_delegate;
test_delegate.set_quit_on_complete(true);
- std::unique_ptr<net::URLRequest> request(context->CreateRequest(
- GURL("http://example.com"), net::DEFAULT_PRIORITY, &test_delegate));
+ std::unique_ptr<net::URLRequest> request(
+ context->CreateRequest(GURL("http://example.com"), net::DEFAULT_PRIORITY,
+ &test_delegate, TRAFFIC_ANNOTATION_FOR_TESTS));
content::ResourceRequestInfo::AllocateForTesting(
request.get(), content::RESOURCE_TYPE_MAIN_FRAME, nullptr, -2, -2, -2,
@@ -262,8 +264,9 @@ TEST_F(ChromeNetworkDelegateTest, HttpRequestCompletionErrorCodes) {
base::HistogramTester histograms;
net::TestDelegate test_delegate;
- std::unique_ptr<net::URLRequest> request(context()->CreateRequest(
- test.url, net::DEFAULT_PRIORITY, &test_delegate));
+ std::unique_ptr<net::URLRequest> request(
+ context()->CreateRequest(test.url, net::DEFAULT_PRIORITY,
+ &test_delegate, TRAFFIC_ANNOTATION_FOR_TESTS));
if (test.is_main_frame) {
request->SetLoadFlags(request->load_flags() |
net::LOAD_MAIN_FRAME_DEPRECATED);
@@ -350,8 +353,9 @@ class ChromeNetworkDelegateSafeSearchTest :
safe_search_util::ClearForceGoogleSafeSearchCountForTesting();
safe_search_util::ClearForceYouTubeRestrictCountForTesting();
- std::unique_ptr<net::URLRequest> request(context_.CreateRequest(
- GURL("http://anyurl.com"), net::DEFAULT_PRIORITY, &delegate_));
+ std::unique_ptr<net::URLRequest> request(
+ context_.CreateRequest(GURL("http://anyurl.com"), net::DEFAULT_PRIORITY,
+ &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
base::RunLoop().RunUntilIdle();
@@ -421,7 +425,7 @@ class ChromeNetworkDelegateAllowedDomainsTest :
allowed_domains_for_apps_.SetValue(allowed);
std::unique_ptr<net::URLRequest> request(context_.CreateRequest(
- url, net::DEFAULT_PRIORITY, &delegate_));
+ url, net::DEFAULT_PRIORITY, &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
base::RunLoop().RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698