Issue 2804005: [Isolates] Removal of miscellaneous statics from the backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2804005: [Isolates] Removal of miscellaneous statics from the backend. (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko, Dmitry Titov

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Removal of miscellaneous statics from the backend. Committed: http://code.google.com/p/v8/source/detail?r=4880

Patch Set 1 #

Patch Set 2 : spacing fixes #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -33 lines)			Patch
M	src/arm/disasm-arm.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/arm/virtual-frame-arm.h	View	1 2	1 chunk	+9 lines, -6 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/disasm.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/disassembler.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View	1 2	2 chunks	+14 lines, -1 line	0 comments	Download
M	src/mips/disasm-mips.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/virtual-frame-light-inl.h	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-16 15:16:45 UTC) #2

LGTM

http://codereview.chromium.org/2804005/diff/13001/11009
File src/isolate.h (right):

http://codereview.chromium.org/2804005/diff/13001/11009#newcode126
src/isolate.h:126: V(bool, virtual_frame_spilled_scope_is_spilled, false)
I think "is_virtual_frame_in_spilled_scope" is a better name.

Expand Messages | Collapse Messages