Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2803983004: Fix mock expectation in SubresourceFilterComponentInstallerTest. (Closed)

Created:
3 years, 8 months ago by Sorin Jianu
Modified:
3 years, 8 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mock expectation in SubresourceFilterComponentInstallerTest. This cleans up the output for SubresourceFilterComponentInstallerTest.TestComponentRegistrationWhenFeatureEnabled [ RUN ] SubresourceFilterComponentInstallerTest.TestComponentRegistrationWhenFeatureEnabled [128216:55036:0407/120537.046:3889874656:ERROR:default_component_installer.cc(363)] Component registration failed for Subresource Filter Rules Review-Url: https://codereview.chromium.org/2803983004 Cr-Commit-Position: refs/heads/master@{#462992} Committed: https://chromium.googlesource.com/chromium/src/+/403cd5140406f53cea0c19524de868635d9e2a14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Sorin Jianu
Charlie, PTAL. Thank you!
3 years, 8 months ago (2017-04-07 19:19:45 UTC) #5
Charlie Harrison
lgtm
3 years, 8 months ago (2017-04-07 19:27:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803983004/1
3 years, 8 months ago (2017-04-07 20:09:10 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:39:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/403cd5140406f53cea0c19524de8...

Powered by Google App Engine
This is Rietveld 408576698