Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2803943007: Un-skipped wpt csp child-src tests (Closed)

Created:
3 years, 8 months ago by andypaicu
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Un-skipped wpt csp child-src tests Moved a couple of support file into "csp/support" from the dodgy "csp/blink-contrib/resources" folder and updated references Updated tests to CSP3 standards Removed local duplicate tests Implemented one new test to mirror a (now deleted) local test BUG=694525 Review-Url: https://codereview.chromium.org/2803943007 Cr-Commit-Position: refs/heads/master@{#463200} Committed: https://chromium.googlesource.com/chromium/src/+/6970070cc5a00b23f3ad8cac1227ff4a13a24cbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -224 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-allowed.sub.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-blocked.sub.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-conflicting-frame-src.sub.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-cross-origin-load.sub.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-redirect-blocked.sub.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-redirect-blocked.sub.html.sub.headers View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-worker-allowed.sub.html View 1 chunk +17 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-worker-allowed.sub.html.sub.headers View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-worker-blocked.sub.html View 1 chunk +26 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/child-src/child-src-worker-blocked.sub.html.sub.headers View 1 chunk +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/post-message.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/postmessage-fail.html View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/postmessage-pass.html View 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/child-src-test.js View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
andypaicu
3 years, 8 months ago (2017-04-07 14:26:23 UTC) #3
Mike West
LGTM. I think we'll want to drop these tests entirely in a release or three, ...
3 years, 8 months ago (2017-04-07 15:57:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803943007/1
3 years, 8 months ago (2017-04-10 08:18:14 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 09:20:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6970070cc5a00b23f3ad8cac1227...

Powered by Google App Engine
This is Rietveld 408576698