Move Mojo types to a new namespace

Move Mojo types to a new namespace

The Mojo type names used in CopylessPaste were too general to be in
namespace blink.mojom.

BUG=693650
Review-Url: https://codereview.chromium.org/2803943004
Cr-Commit-Position: refs/heads/master@{#462790}
Committed: https://chromium.googlesource.com/chromium/src/+/465fa2f3b877316159a8661723bf9a205e09dfe7

[wychen, 2017-04-06 20:15:49]

wychen@chromium.org changed reviewers:
+ dcheng@chromium.org, dproctor@google.com, esprehn@chromium.org

[wychen, 2017-04-06 20:15:50]

PTAL

[esprehn, 2017-04-06 21:15:27]

Can you explain why you need both the old and new mojom files (with the
deprecated name?) It'd be nice to not have both at the same time. :)

[wychen, 2017-04-06 21:21:55]

On 2017/04/06 21:15:27, esprehn wrote:
> Can you explain why you need both the old and new mojom files (with the
> deprecated name?) It'd be nice to not have both at the same time. :)

Oh, it's because the interface is shared by both upstream and downstream code.
We need to keep the old interface for downstream to compile.
It will be 3 CLs:
- Add the new interface in upstream.
- Change to the new interface in downstream.
- Remove the old interface in upstream.

[esprehn, 2017-04-06 21:23:30]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org

[esprehn, 2017-04-06 21:23:30]

What does downstream mean? In general we don't put effort into not breaking
things that are outside src/ since it privileges that project in a way no other
project (ex. Electron) is.

FYI dglazkov@

[wychen, 2017-04-06 21:31:47]

On 2017/04/06 21:23:30, esprehn wrote:
> What does downstream mean? In general we don't put effort into not breaking
> things that are outside src/ since it privileges that project in a way no
other
> project (ex. Electron) is.
> 
> FYI dglazkov@

The downstream is the private Clank repo, where most of the Java side of the
CopylessPaste feature lives.
We tend to treat Clank repo part of src/.

[esprehn, 2017-04-06 21:32:41]

Okay, this change lgtm, I'll leave the repo deps discussion/decision to
dlgazkov@

[wychen, 2017-04-06 21:34:52]

wychen@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[wychen, 2017-04-06 21:34:53]

Add Maria for the Java change.

[dcheng, 2017-04-06 21:42:12]

mojo lgtm

https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:5:
module blink.mojom.copyless;
Nit: document_metadata seems like a more appropriate namespace

[dproctor, 2017-04-06 22:06:02]

lgtm

https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:5:
module blink.mojom.copyless;
On 2017/04/06 21:42:12, dcheng wrote:
> Nit: document_metadata seems like a more appropriate namespace

I agree.

[dproctor, 2017-04-06 22:06:05]

lgtm

[dglazkov, 2017-04-06 22:16:26]

LGTM, will discuss the private repo offline.

[wychen, 2017-04-06 22:58:56]

https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
File
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
(right):

https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:5:
module blink.mojom.copyless;
On 2017/04/06 22:06:02, dproctor wrote:
> On 2017/04/06 21:42:12, dcheng wrote:
> > Nit: document_metadata seems like a more appropriate namespace
> 
> I agree.

In the hindsight, it's quite obvious. Why didn't I think of it? :p
Will do.

[Maria, 2017-04-06 23:15:47]

On 2017/04/06 22:58:56, wychen wrote:
>
https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
> File
>
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom
> (right):
> 
>
https://codereview.chromium.org/2803943004/diff/1/third_party/WebKit/public/p...
>
third_party/WebKit/public/platform/modules/document_metadata/copyless_paste.mojom:5:
> module blink.mojom.copyless;
> On 2017/04/06 22:06:02, dproctor wrote:
> > On 2017/04/06 21:42:12, dcheng wrote:
> > > Nit: document_metadata seems like a more appropriate namespace
> > 
> > I agree.
> 
> In the hindsight, it's quite obvious. Why didn't I think of it? :p
> Will do.

[Maria, 2017-04-06 23:15:57]

lgtm for java

[wychen, 2017-04-07 00:43:57]

The CQ bit was checked by wychen@chromium.org

[wychen, 2017-04-07 00:43:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dproctor@google.com,
esprehn@chromium.org, dcheng@chromium.org, dglazkov@chromium.org,
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2803943004/#ps20001
(title: "rename")

[commit-bot: I haz the power, 2017-04-07 00:44:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:08:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491525837271790,
"parent_rev": "a61ff59e5d2030e2aaf4db89d8bb6767c410eb6d", "commit_rev":
"465fa2f3b877316159a8661723bf9a205e09dfe7"}

[commit-bot: I haz the power, 2017-04-07 06:09:33]

Description was changed from

==========
Move Mojo types to a new namespace

The Mojo type names used in CopylessPaste were too general to be in
namespace blink.mojom.

BUG=693650
==========

to

==========
Move Mojo types to a new namespace

The Mojo type names used in CopylessPaste were too general to be in
namespace blink.mojom.

BUG=693650

Review-Url: https://codereview.chromium.org/2803943004
Cr-Commit-Position: refs/heads/master@{#462790}
Committed:
https://chromium.googlesource.com/chromium/src/+/465fa2f3b877316159a8661723bf...
==========

[commit-bot: I haz the power, 2017-04-07 06:09:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/465fa2f3b877316159a8661723bf...