Adds ash_mus_unittests to FYI bot

Adds ash_mus_unittests to FYI bot

There are a slew of failures that need to be investigated. Rather than
early out all the tests I'm adding a filter file. This makes it easier
to retry tests as functionality is addded.

I've also cleaned up a handful of things in looking at failures.

BUG=705715
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2803933003
Cr-Commit-Position: refs/heads/master@{#462628}
Committed: https://chromium.googlesource.com/chromium/src/+/ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4

[sky, 2017-04-06 18:15:13]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:16:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-04-06 18:43:23]

lgtm with minor/optional nits. Nice extra cleanups.

https://codereview.chromium.org/2803933003/diff/20001/ash/app_list/app_list_p...
File ash/app_list/app_list_presenter_delegate_unittest.cc (right):

https://codereview.chromium.org/2803933003/diff/20001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate_unittest.cc:25: int64_t
GetPrimaryDisplayId() {
optional nit: Add this to AshTestBase/AshTestHelper like GetSecondaryDisplay?

https://codereview.chromium.org/2803933003/diff/20001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate_unittest.cc:28: }  // namespace
nit: blank line above

https://codereview.chromium.org/2803933003/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2803933003/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.fyi.json:11794:
"--test-launcher-filter-file=../../testing/buildbot/filters/ash_mus_unittests.filter"
optional nit: prepend mojo.fyi to the file name like
mojo.fyi.browser_tests.filter? (or maybe that would just make it awkward to use
for non-fyi later on?)

[sky, 2017-04-06 19:00:11]

https://codereview.chromium.org/2803933003/diff/20001/ash/app_list/app_list_p...
File ash/app_list/app_list_presenter_delegate_unittest.cc (right):

https://codereview.chromium.org/2803933003/diff/20001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate_unittest.cc:25: int64_t
GetPrimaryDisplayId() {
On 2017/04/06 18:43:22, msw wrote:
> optional nit: Add this to AshTestBase/AshTestHelper like GetSecondaryDisplay?

I think this (and some of the other utility functions in AshTestBase/Helper)
belong in a test_utils files. I'm going to leave it here for now.

https://codereview.chromium.org/2803933003/diff/20001/ash/app_list/app_list_p...
ash/app_list/app_list_presenter_delegate_unittest.cc:28: }  // namespace
On 2017/04/06 18:43:22, msw wrote:
> nit: blank line above

Done.

https://codereview.chromium.org/2803933003/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.fyi.json (right):

https://codereview.chromium.org/2803933003/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.fyi.json:11794:
"--test-launcher-filter-file=../../testing/buildbot/filters/ash_mus_unittests.filter"
On 2017/04/06 18:43:22, msw wrote:
> optional nit: prepend mojo.fyi to the file name like
> mojo.fyi.browser_tests.filter? (or maybe that would just make it awkward to
use
> for non-fyi later on?)

Indeed. I'm hoping this quickly transitions to the main waterfall.

[sky, 2017-04-06 19:00:24]

The CQ bit was checked by sky@chromium.org

[sky, 2017-04-06 19:00:24]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2803933003/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2017-04-06 19:01:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:28:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491505224368240,
"parent_rev": "0f822b53c05998de526f73fc5e4187650dcf0336", "commit_rev":
"ed6da57dfdcee72b4fcc5e925b6b8e6384d500f4"}

[commit-bot: I haz the power, 2017-04-06 21:29:48]

Description was changed from

==========
Adds ash_mus_unittests to FYI bot

There are a slew of failures that need to be investigated. Rather than
early out all the tests I'm adding a filter file. This makes it easier
to retry tests as functionality is addded.

I've also cleaned up a handful of things in looking at failures.

BUG=705715
TEST=this is test change
R=msw@chromium.org
==========

to

==========
Adds ash_mus_unittests to FYI bot

There are a slew of failures that need to be investigated. Rather than
early out all the tests I'm adding a filter file. This makes it easier
to retry tests as functionality is addded.

I've also cleaned up a handful of things in looking at failures.

BUG=705715
TEST=this is test change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2803933003
Cr-Commit-Position: refs/heads/master@{#462628}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed6da57dfdcee72b4fcc5e925b6b...
==========

[commit-bot: I haz the power, 2017-04-06 21:29:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ed6da57dfdcee72b4fcc5e925b6b...