Add options.omitErrorMessage for should.throw()

Add options.omitErrorMessage for should.throw()

This suppresses unnecessary error message (due to the local hardware
configuration) from the exception from should.throw().

BUG=709167
TEST=webaudio/dom-exceptions.html

Review-Url: https://codereview.chromium.org/2803913003
Cr-Commit-Position: refs/heads/master@{#462680}
Committed: https://chromium.googlesource.com/chromium/src/+/a9f9abb3a264c3224b05d41a25790a8d3d16be18

[hongchan, 2017-04-06 19:59:35]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-04-06 19:59:35]

PTAL. Now dom-exceptions.html passes on my 8-channel audio interface.

[Raymond Toy, 2017-04-06 20:06:59]

https://codereview.chromium.org/2803913003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2803913003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:295: ? ''
If omitErrorMessage is true, perhaps we want to output something like "[error
message omitted]".  To make a distinction in the output between throw() and
throw('errortype', {omitErrorMessage: true})

[hongchan, 2017-04-06 20:38:17]

https://codereview.chromium.org/2803913003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right):

https://codereview.chromium.org/2803913003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/resources/audit.js:295: ? ''
On 2017/04/06 20:06:59, Raymond Toy wrote:
> If omitErrorMessage is true, perhaps we want to output something like "[error
> message omitted]".  To make a distinction in the output between throw() and
> throw('errortype', {omitErrorMessage: true})
> 

Done.

[Raymond Toy, 2017-04-06 20:42:02]

lgtm

[hongchan, 2017-04-06 20:42:28]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2017-04-06 20:43:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:30:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491511348936980,
"parent_rev": "7d3049a95961ec0b6601a15a0b0335e11acc01c8", "commit_rev":
"a9f9abb3a264c3224b05d41a25790a8d3d16be18"}

[commit-bot: I haz the power, 2017-04-06 23:31:50]

Description was changed from

==========
Add options.omitErrorMessage for should.throw()

This suppresses unnecessary error message (due to the local hardware
configuration) from the exception from should.throw().

BUG=709167
TEST=webaudio/dom-exceptions.html
==========

to

==========
Add options.omitErrorMessage for should.throw()

This suppresses unnecessary error message (due to the local hardware
configuration) from the exception from should.throw().

BUG=709167
TEST=webaudio/dom-exceptions.html

Review-Url: https://codereview.chromium.org/2803913003
Cr-Commit-Position: refs/heads/master@{#462680}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9f9abb3a264c3224b05d41a2579...
==========

[commit-bot: I haz the power, 2017-04-06 23:31:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a9f9abb3a264c3224b05d41a2579...