Reuse the code within UpdateCheckMark()

ash/common/system/tray/tray_utils.cc

Index: ash/common/system/tray/tray_utils.cc
diff --git a/ash/common/system/tray/tray_utils.cc b/ash/common/system/tray/tray_utils.cc
index 28299cc66e645f8aec1284a1fa6e5c8661a6dda9..83fa10c1fb04288434bd9e93b1686f240e8e357a 100644
--- a/ash/common/system/tray/tray_utils.cc
+++ b/ash/common/system/tray/tray_utils.cc
@@ -4,7 +4,11 @@
 
 #include "ash/common/system/tray/tray_utils.h"
 
+#include "ash/common/system/tray/hover_highlight_view.h"
+#include "ash/resources/vector_icons/vector_icons.h"
+#include "ui/gfx/color_palette.h"
 #include "ui/gfx/font_list.h"
+#include "ui/gfx/paint_vector_icon.h"
 #include "ui/views/controls/label.h"
 
 namespace ash {
@@ -17,4 +21,19 @@ void SetupLabelForTray(views::Label* label) {
       gfx::FontList().Derive(2, gfx::Font::NORMAL, gfx::Font::Weight::MEDIUM));
 }
 
+void SetCheckMarkVisible(HoverHighlightView* container) {
+  gfx::ImageSkia check_mark =
+      CreateVectorIcon(kCheckCircleIcon, gfx::kGoogleGreen700);
+  container->AddRightIcon(check_mark, check_mark.width());
+  container->SetRightViewVisible(true);
+  container->SetAccessiblityState(
+      HoverHighlightView::AccessibilityState::CHECKED_CHECKBOX);
+}
+
+void SetCheckMarkInvisible(HoverHighlightView* container) {
+  container->SetRightViewVisible(false);
+  container->SetAccessiblityState(
+      HoverHighlightView::AccessibilityState::UNCHECKED_CHECKBOX);

[tdanderson, 2017/04/06 17:52:09]

The two new functions you have introduced here are quite similar, and having two
functions instead of one requires more code at each call site. As one possible
idea, consider something such as:

UpdateCheckMarkVisibility(container, checked)

instead of:

if (checked)
  SetCheckMarkVisible(container);
else
  SetCheckMarkInvisible(container);

[minch1, 2017/04/06 18:05:47]

The logic of enable and disable check mark in CommonPaletteTool is separate.
That's the reason I introduced two functions here. And there is no
AddRightIcon() in CommonPaletteTool too. So actually I introduced three
functions here. Can  you help check PS#5 for this?

[minch1, 2017/04/06 18:09:41]

Maybe I can add one more function here to combine these two functions (so there
will have 4 funcs here), then there will be only one line in the call site?

+}
+
 }  // namespace ash