Reuse the code within UpdateCheckMark()

ash/common/system/tray/tray_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_utils.h"
 
+#include "ash/common/system/tray/hover_highlight_view.h"
+#include "ash/resources/vector_icons/vector_icons.h"
+#include "ui/gfx/color_palette.h"
 #include "ui/gfx/font_list.h"
+#include "ui/gfx/paint_vector_icon.h"
 #include "ui/views/controls/label.h"
 
 namespace ash {
 
 void SetupLabelForTray(views::Label* label) {
   // The text is drawn on an transparent bg, so we must disable subpixel
   // rendering.
   label->SetSubpixelRenderingEnabled(false);
   label->SetFontList(
       gfx::FontList().Derive(2, gfx::Font::NORMAL, gfx::Font::Weight::MEDIUM));
 }
 
+void SetCheckMarkVisible(HoverHighlightView* container) {
+  gfx::ImageSkia check_mark =
+      CreateVectorIcon(kCheckCircleIcon, gfx::kGoogleGreen700);
+  container->AddRightIcon(check_mark, check_mark.width());
+  container->SetRightViewVisible(true);
+  container->SetAccessiblityState(
+      HoverHighlightView::AccessibilityState::CHECKED_CHECKBOX);
+}
+
+void SetCheckMarkInvisible(HoverHighlightView* container) {
+  container->SetRightViewVisible(false);
+  container->SetAccessiblityState(
+      HoverHighlightView::AccessibilityState::UNCHECKED_CHECKBOX);

[tdanderson, 2017/04/06 17:52:09]

The two new functions you have introduced here are quite similar, and having two
functions instead of one requires more code at each call site. As one possible
idea, consider something such as:

UpdateCheckMarkVisibility(container, checked)

instead of:

if (checked)
  SetCheckMarkVisible(container);
else
  SetCheckMarkInvisible(container);

[minch1, 2017/04/06 18:05:47]

The logic of enable and disable check mark in CommonPaletteTool is separate.
That's the reason I introduced two functions here. And there is no
AddRightIcon() in CommonPaletteTool too. So actually I introduced three
functions here. Can  you help check PS#5 for this?

[minch1, 2017/04/06 18:09:41]

Maybe I can add one more function here to combine these two functions (so there
will have 4 funcs here), then there will be only one line in the call site?

+}
+
 }  // namespace ash