Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2803853002: MD Settings: Restore focus when channel switcher dialog is closed. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore focus when channel switcher dialog is closed. BUG=709148 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2803853002 Cr-Commit-Position: refs/heads/master@{#462729} Committed: https://chromium.googlesource.com/chromium/src/+/31e3ce11e88b1b416596e490931d7805e2263db8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M chrome/browser/resources/settings/about_page/detailed_build_info.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/about_page/detailed_build_info.js View 1 chunk +7 lines, -11 lines 1 comment Download

Messages

Total messages: 18 (12 generated)
dpapad
3 years, 8 months ago (2017-04-05 23:28:20 UTC) #6
dpapad
On 2017/04/05 at 23:28:20, dpapad wrote: > Friendly ping.
3 years, 8 months ago (2017-04-06 22:36:05 UTC) #10
stevenjb
lgtm https://codereview.chromium.org/2803853002/diff/1/chrome/browser/resources/settings/about_page/detailed_build_info.js File chrome/browser/resources/settings/about_page/detailed_build_info.js (right): https://codereview.chromium.org/2803853002/diff/1/chrome/browser/resources/settings/about_page/detailed_build_info.js#newcode98 chrome/browser/resources/settings/about_page/detailed_build_info.js:98: this.updateChannelInfo_(); Ahh, much nicer :) Cheers!
3 years, 8 months ago (2017-04-06 23:08:06 UTC) #11
stevenjb
lgtm lgtm https://codereview.chromium.org/2803853002/diff/1/chrome/browser/resources/settings/about_page/detailed_build_info.js File chrome/browser/resources/settings/about_page/detailed_build_info.js (right): https://codereview.chromium.org/2803853002/diff/1/chrome/browser/resources/settings/about_page/detailed_build_info.js#newcode98 chrome/browser/resources/settings/about_page/detailed_build_info.js:98: this.updateChannelInfo_(); Ahh, much nicer :) Cheers!
3 years, 8 months ago (2017-04-06 23:08:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803853002/1
3 years, 8 months ago (2017-04-06 23:53:54 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:20:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/31e3ce11e88b1b416596e490931d...

Powered by Google App Engine
This is Rietveld 408576698