Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2803823005: Check for readyState in video pixel tests (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for readyState in video pixel tests Otherwise it's possible the video could be loaded before this code runs, in which case the canplaythrough event won't happen and the test will hang. TBR=kbr@chromium.org BUG=704389 Review-Url: https://codereview.chromium.org/2803823005 Cr-Commit-Position: refs/heads/master@{#462667} Committed: https://chromium.googlesource.com/chromium/src/+/2b277506fe914467d4bf3f0e3b1d807586d93408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/test/data/gpu/pixel_video_mp4.html View 1 chunk +5 lines, -1 line 0 comments Download
M content/test/data/gpu/pixel_video_vp9.html View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803823005/1
3 years, 8 months ago (2017-04-06 22:29:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2b277506fe914467d4bf3f0e3b1d807586d93408
3 years, 8 months ago (2017-04-06 23:14:11 UTC) #10
Ken Russell (switch to Gerrit)
3 years, 8 months ago (2017-04-06 23:16:23 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698