Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 2803813002: Disable flaky tests that are going to be broken by data URL deprecation (Closed)
Patch Set: Disable flaky tests that are going to be broken by data URL deprecation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_apitest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc
index fe742323629f736b579110c7d4204ea8ed21c9f2..745edfe7243efa94cd6d76785c820085c5799855 100644
--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc
@@ -533,17 +533,10 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestExecuteScriptFail) {
RunTest("testExecuteScriptFail", "web_view/apitest");
}
-// Failes on Linux/CrOS. https://crbug.com/702918
-#if defined(OS_LINUX) || defined(OS_CHROMEOS)
-#define MAYBE_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
- DISABLED_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
-#else
-#define MAYBE_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
- TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
-#endif
+// Flaky and likely not testing the right assertion. https://crbug.com/702918
IN_PROC_BROWSER_TEST_F(
WebViewAPITest,
- MAYBE_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
+ DISABLED_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
RunTest("testExecuteScriptIsAbortedWhenWebViewSourceIsChanged",
"web_view/apitest");
}
« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698