Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2803813002: Disable flaky tests that are going to be broken by data URL deprecation (Closed)
Patch Set: Disable flaky tests that are going to be broken by data URL deprecation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index a8f1beca36a81fe08fa25bc6b0e81e48ac219da3..89be3d1791e56b8c13ad251ed5972eabb8691dfe 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -1438,17 +1438,10 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestExecuteScript) {
TestHelper("testExecuteScript", "web_view/shim", NO_TEST_SERVER);
}
-// Flaky on Linux. See https://crbug.com/703727.
-#if defined(OS_LINUX)
-#define MAYBE_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
- DISABLED_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
-#else
-#define MAYBE_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged \
- Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged
-#endif
+// Flaky and likely not testing the right assertion. https://crbug.com/703727
IN_PROC_BROWSER_TEST_P(
WebViewTest,
- MAYBE_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
+ DISABLED_Shim_TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged) {
TestHelper("testExecuteScriptIsAbortedWhenWebViewSourceIsChanged",
"web_view/shim",
NO_TEST_SERVER);
« no previous file with comments | « no previous file | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698