Ensure strikethrough font renders in omnibox on iOS 10.3

Ensure strikethrough font renders in omnibox on iOS 10.3

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. To workaround this, apply a NSBaselineOffsetAttributeName
attribute with its default value of 0.

BUG=699702
TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.

Review-Url: https://codereview.chromium.org/2803783002
Cr-Commit-Position: refs/heads/master@{#462519}
Committed: https://chromium.googlesource.com/chromium/src/+/2352cecca1d2738c6c6b970708286211c29cf16e

[elawrence, 2017-04-06 14:45:53]

elawrence@chromium.org changed reviewers:
+ rohitrao@chromium.org

[elawrence, 2017-04-06 14:45:53]

PTAL? I've confirmed in the 10.3 emulators that this fixes the issue, but I
haven't yet had any luck getting my self-built bits onto an actual device to
confirm the fix.

[rohitrao (ping after 24h), 2017-04-06 14:51:21]

https://codereview.chromium.org/2803783002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm (right):

https://codereview.chromium.org/2803783002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm:674: // Workaround: Add an
attribute to allow strikethough to apply on iOS 10.3.
Should we only apply this attribute if running on 10.3 and above?  Is there any
chance this could break behavior on older OS versions?

[elawrence, 2017-04-06 15:03:30]

On 2017/04/06 14:51:21, rohitrao wrote:
>
https://codereview.chromium.org/2803783002/diff/1/ios/chrome/browser/ui/omnib...
> File ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm (right):
> 
>
https://codereview.chromium.org/2803783002/diff/1/ios/chrome/browser/ui/omnib...
> ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm:674: // Workaround: Add an
> attribute to allow strikethough to apply on iOS 10.3.
> Should we only apply this attribute if running on 10.3 and above?  Is there
any
> chance this could break behavior on older OS versions?

I can look for a means of checking the iOS version to limit the patch. I /don't
think/ this should break behavior on older OS versions, insofar as the attribute
introduced seems to have existed for many releases with the default value of 0.
But I'm definitely not an expert on iOS.

[elawrence, 2017-04-06 15:36:15]

No limited to 10.3+

[elawrence, 2017-04-06 15:36:49]

On 2017/04/06 15:36:15, elawrence wrote:
> No limited to 10.3+

typo. "Now limited to 10.3+". Sorry for the spam.

[rohitrao (ping after 24h), 2017-04-06 15:58:03]

lgtm

[elawrence, 2017-04-06 16:16:51]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 17:05:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491495411926940,
"parent_rev": "35be0078448bc5bc5198eac37562089682a555c1", "commit_rev":
"b8692f7ab29657896993a002f339d3e8e039f5a8"}

[commit-bot: I haz the power, 2017-04-06 17:11:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491495411926940,
"parent_rev": "907b20bc72bb3f9e8c566bb12626dcbb82967b35", "commit_rev":
"2352cecca1d2738c6c6b970708286211c29cf16e"}

[commit-bot: I haz the power, 2017-04-06 17:12:31]

Description was changed from

==========
Ensure strikethrough font renders in omnibox on iOS 10.3

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. To workaround this, apply a NSBaselineOffsetAttributeName
attribute with its default value of 0.

BUG=699702
TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.
==========

to

==========
Ensure strikethrough font renders in omnibox on iOS 10.3

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. To workaround this, apply a NSBaselineOffsetAttributeName
attribute with its default value of 0.

BUG=699702
TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.

Review-Url: https://codereview.chromium.org/2803783002
Cr-Commit-Position: refs/heads/master@{#462519}
Committed:
https://chromium.googlesource.com/chromium/src/+/2352cecca1d2738c6c6b97070828...
==========

[commit-bot: I haz the power, 2017-04-06 17:12:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2352cecca1d2738c6c6b97070828...