Clean up code in SignInPreference

Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from onBindView.
4. Removed code to change enabled state.

BUG=none

Review-Url: https://codereview.chromium.org/2803753002
Cr-Commit-Position: refs/heads/master@{#462860}
Committed: https://chromium.googlesource.com/chromium/src/+/e7274aef78e201e05c8fbcaa160717f3bdec968b

[bsazonov, 2017-04-05 18:25:56]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsazonov, 2017-04-05 18:28:25]

Description was changed from

==========
Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from enabled state manipulations.

BUG=none
==========

to

==========
Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from enabled state manipulations.
4. Removed code to change enabled state.

BUG=none
==========

[bsazonov, 2017-04-05 18:29:35]

Description was changed from

==========
Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from enabled state manipulations.
4. Removed code to change enabled state.

BUG=none
==========

to

==========
Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from onBindView.
4. Removed code to change enabled state.

BUG=none
==========

[commit-bot: I haz the power, 2017-04-05 19:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 19:16:39]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-04-07 13:00:34]

Patchset #1 (id:1) has been deleted

[bsazonov, 2017-04-07 13:00:51]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 13:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsazonov, 2017-04-07 13:03:19]

bsazonov@chromium.org changed reviewers:
+ bauerb@chromium.org

[bsazonov, 2017-04-07 13:03:20]

Bernhard, please take a look.

[commit-bot: I haz the power, 2017-04-07 13:35:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:35:47]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-04-07 14:05:48]

lgtm

https://codereview.chromium.org/2803753002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
(right):

https://codereview.chromium.org/2803753002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java:127:
final Profile profile = Profile.getLastUsedProfile();
I don't think this needs to be final.

https://codereview.chromium.org/2803753002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java:166:
private static void setEnabledRecursive(View view, boolean enabled) {
This method already exists in ViewUtils.

[bsazonov, 2017-04-07 14:20:12]

Thanks!

https://codereview.chromium.org/2803753002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
(right):

https://codereview.chromium.org/2803753002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java:127:
final Profile profile = Profile.getLastUsedProfile();
On 2017/04/07 14:05:48, Bernhard Bauer wrote:
> I don't think this needs to be final.

Done.

https://codereview.chromium.org/2803753002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java:166:
private static void setEnabledRecursive(View view, boolean enabled) {
On 2017/04/07 14:05:48, Bernhard Bauer wrote:
> This method already exists in ViewUtils.

Oh, I haven't found it. Thanks for the tip!

[bsazonov, 2017-04-07 14:21:36]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-04-07 14:21:37]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2803753002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-07 14:21:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 14:56:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491574896952560,
"parent_rev": "e1920d9dc4d5cb935cbf0f27c0e5beb06c8a0c25", "commit_rev":
"e7274aef78e201e05c8fbcaa160717f3bdec968b"}

[commit-bot: I haz the power, 2017-04-07 14:57:36]

Description was changed from

==========
Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from onBindView.
4. Removed code to change enabled state.

BUG=none
==========

to

==========
Clean up code in SignInPreference

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from onBindView.
4. Removed code to change enabled state.

BUG=none

Review-Url: https://codereview.chromium.org/2803753002
Cr-Commit-Position: refs/heads/master@{#462860}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7274aef78e201e05c8fbcaa1607...
==========

[commit-bot: I haz the power, 2017-04-07 14:57:38]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7274aef78e201e05c8fbcaa1607...