Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2803743002: Mojofy GpuHostMsg_FieldTrialActivated (Closed)

Created:
3 years, 8 months ago by chiniforooshan
Modified:
3 years, 8 months ago
Reviewers:
Tom Sepez, sadrul, piman
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojofy GpuHostMsg_FieldTrialActivated Also, a little bit of cleaning mojo interface registration in gpu_process_host. BUG=698284 Review-Url: https://codereview.chromium.org/2803743002 Cr-Commit-Position: refs/heads/master@{#462649} Committed: https://chromium.googlesource.com/chromium/src/+/701fa21b5ccf60143b103799f83cae7c51e6b5ee

Patch Set 1 #

Patch Set 2 : fix BUILD #

Patch Set 3 : fix warning #

Total comments: 4

Patch Set 4 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -69 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 5 chunks +1 line, -23 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/gpu_host_messages.h View 1 chunk +0 lines, -22 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_message_start.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 27 (17 generated)
chiniforooshan
PTAL
3 years, 8 months ago (2017-04-05 20:43:16 UTC) #10
chiniforooshan
I think the ios-simulator failure is because the bot ran out of space.
3 years, 8 months ago (2017-04-05 23:13:40 UTC) #13
sadrul
LGTM! https://codereview.chromium.org/2803743002/diff/40001/content/common/BUILD.gn File content/common/BUILD.gn (left): https://codereview.chromium.org/2803743002/diff/40001/content/common/BUILD.gn#oldcode153 content/common/BUILD.gn:153: "gpu_host_messages.h", yay!!
3 years, 8 months ago (2017-04-06 04:34:23 UTC) #14
chiniforooshan
Thanks. +Antoine (content owner) +Tom (security) https://codereview.chromium.org/2803743002/diff/40001/content/common/BUILD.gn File content/common/BUILD.gn (left): https://codereview.chromium.org/2803743002/diff/40001/content/common/BUILD.gn#oldcode153 content/common/BUILD.gn:153: "gpu_host_messages.h", On 2017/04/06 ...
3 years, 8 months ago (2017-04-06 14:17:05 UTC) #16
chiniforooshan
3 years, 8 months ago (2017-04-06 14:17:59 UTC) #18
Tom Sepez
LGTM otherwise. https://codereview.chromium.org/2803743002/diff/40001/content/common/gpu_host_messages.h File content/common/gpu_host_messages.h (left): https://codereview.chromium.org/2803743002/diff/40001/content/common/gpu_host_messages.h#oldcode15 content/common/gpu_host_messages.h:15: #define IPC_MESSAGE_START GpuMsgStart Can you remove the ...
3 years, 8 months ago (2017-04-06 16:59:06 UTC) #19
chiniforooshan
https://codereview.chromium.org/2803743002/diff/40001/content/common/gpu_host_messages.h File content/common/gpu_host_messages.h (left): https://codereview.chromium.org/2803743002/diff/40001/content/common/gpu_host_messages.h#oldcode15 content/common/gpu_host_messages.h:15: #define IPC_MESSAGE_START GpuMsgStart On 2017/04/06 16:59:05, Tom Sepez wrote: ...
3 years, 8 months ago (2017-04-06 17:04:36 UTC) #20
piman
lgtm
3 years, 8 months ago (2017-04-06 20:35:33 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803743002/60001
3 years, 8 months ago (2017-04-06 20:37:39 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:24:12 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/701fa21b5ccf60143b103799f83c...

Powered by Google App Engine
This is Rietveld 408576698