Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2803733002: Convert ASSERT(foo) to DCHECK(foo) in platform/audio (Closed)

Created:
3 years, 8 months ago by hongchan
Modified:
3 years, 8 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change from ASSERT() to DCHECK() mechanically, replacing the assertion with a single argument only. I used the following script: ``` cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio find . -type f -exec sed -i -E 's:(\s)ASSERT\(([^ ]+)\)\;:\1DCHECK\(\2\)\;:g' {} \; ``` BUG=707655 Review-Url: https://codereview.chromium.org/2803733002 Cr-Commit-Position: refs/heads/master@{#462261} Committed: https://chromium.googlesource.com/chromium/src/+/497c247fb764715c64de5a4e73dbd014cb13bb65

Patch Set 1 : Mechanical change from ASSERT(foo) to DCHECK(foo) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -90 lines) Patch
M third_party/WebKit/Source/platform/audio/AudioArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioBus.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioChannel.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioResampler.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/DirectConvolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/DownSampler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/FFTConvolver.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFElevation.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFKernel.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFPanner.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/IIRFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/Reverb.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/SincResampler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/StereoPanner.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/UpSampler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/VectorMath.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
hongchan
PTAL.
3 years, 8 months ago (2017-04-05 21:08:28 UTC) #7
hongchan
Deleted manual changes (PS2/PS3). PTAL.
3 years, 8 months ago (2017-04-05 21:17:56 UTC) #11
Raymond Toy
lgtm
3 years, 8 months ago (2017-04-05 21:21:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803733002/1
3 years, 8 months ago (2017-04-05 21:32:51 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 23:15:27 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/497c247fb764715c64de5a4e73db...

Powered by Google App Engine
This is Rietveld 408576698