Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2803693006: [regexp] add more tests for binary property classes. (Closed)

Created:
3 years, 8 months ago by Yang
Modified:
3 years, 8 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] add more tests for binary property classes. R=jgruber@chromium.org BUG=v8:4743 Review-Url: https://codereview.chromium.org/2803693006 Cr-Commit-Position: refs/heads/master@{#44512} Committed: https://chromium.googlesource.com/v8/v8/+/582921454d593607cf1c49322f2b412fe7002a2b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add negative cases. #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M test/mjsunit/harmony/regexp-property-binary.js View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Yang
3 years, 8 months ago (2017-04-07 12:24:59 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2803693006/diff/1/test/mjsunit/harmony/regexp-property-binary.js File test/mjsunit/harmony/regexp-property-binary.js (right): https://codereview.chromium.org/2803693006/diff/1/test/mjsunit/harmony/regexp-property-binary.js#newcode23 test/mjsunit/harmony/regexp-property-binary.js:23: t(/\p{ID_Start}+/u, "a"); Nice! Maybe a couple of negative ...
3 years, 8 months ago (2017-04-07 12:44:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803693006/40001
3 years, 8 months ago (2017-04-10 09:44:32 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 10:19:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/582921454d593607cf1c49322f2b412fe70...

Powered by Google App Engine
This is Rietveld 408576698